Skip to content

rdk: remove dangling raspi reference#11508

Open
anshugupta27 wants to merge 1 commit into
youtube:mainfrom
anshugupta27:fix-rdk-rpi-gles2-dep
Open

rdk: remove dangling raspi reference#11508
anshugupta27 wants to merge 1 commit into
youtube:mainfrom
anshugupta27:fix-rdk-rpi-gles2-dep

Conversation

@anshugupta27

@anshugupta27 anshugupta27 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

The starboard/raspi directory has been deleted as part of the raspi-2 deprecation. This removes the dangling reference to //starboard/raspi/shared/system_gles2.cc for the rdk-rpi target.
Bug: 500021808

@anshugupta27
anshugupta27 requested a review from a team as a code owner July 23, 2026 02:39
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Gemini Suggested Commit Message


Error: Could not parse a valid response from the Gemini API. Please check the API response logs in the workflow run.

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes support and references for the Raspberry Pi (raspi/raspi-2) platform across configuration, test, and build files. The review feedback points out that removing the rdk-rpi specific system_gles2.cc override in BUILD.gn could break the rdk-rpi target if it is still supported, and suggests either moving the Raspberry Pi-specific GLES initialization code to the rdk directory or cleaning up the rdk-rpi target entirely.

I am having trouble creating individual review comments. Click here to see my feedback.

starboard/contrib/rdk/src/third_party/starboard/rdk/shared/BUILD.gn (299-306)

high

Simply removing the rdk-rpi specific system_gles2.cc override will cause the rdk-rpi target to fall back to the generic //starboard/shared/gles/system_gles2.cc. If rdk-rpi is still a supported target, it likely requires the Raspberry Pi-specific GLES/EGL initialization that was previously in //starboard/raspi/shared/system_gles2.cc. If so, that file should be copied/moved to the rdk directory (e.g., starboard/contrib/rdk/shared/system_gles2_rpi.cc) and referenced here, rather than completely removing the override. If rdk-rpi is no longer supported, the target itself should be cleaned up.

@anshugupta27
anshugupta27 changed the base branch from main to 27.lts July 23, 2026 02:41
@anshugupta27
anshugupta27 changed the base branch from 27.lts to main July 23, 2026 02:41
@anshugupta27
anshugupta27 force-pushed the fix-rdk-rpi-gles2-dep branch from 5dd85d2 to 949534d Compare July 23, 2026 02:43
@anshugupta27
anshugupta27 force-pushed the fix-rdk-rpi-gles2-dep branch from 949534d to 4790633 Compare July 23, 2026 03:36
@anshugupta27 anshugupta27 changed the title rdk: remove dangling raspi reference from BUILD.gn rdk: remove dangling raspi reference Jul 23, 2026
- Remove broken reference to //starboard/raspi/shared/system_gles2.cc in starboard/contrib/rdk/src/third_party/starboard/rdk/shared/BUILD.gn.
- Delete deprecated evergreen-arm-hardfp-raspi package.
@anshugupta27
anshugupta27 force-pushed the fix-rdk-rpi-gles2-dep branch from 4790633 to 2f163b3 Compare July 23, 2026 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant