Skip to content

aosp: report POSIX symlink st_size from lstat #11332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rogerzanoni wants to merge 1 commit into
base: main
Choose a base branch
from
Open

aosp: report POSIX symlink st_size from lstat #11332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion starboard/android/shared/posix_emu/stat.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
#include <android/asset_manager.h>
#include <errno.h>
#include <fcntl.h>
#include <limits.h>
#include <sys/stat.h>
#include <unistd.h>

#include "starboard/android/shared/file_internal.h"

Expand All @@ -38,7 +40,21 @@ int __wrap_stat(const char* path, struct stat* info) {

int __wrap_fstatat(int dirfd, const char* path, struct stat* info, int flags) {
if (!IsAndroidAssetPath(path)) {
return __real_fstatat(dirfd, path, info, flags);
int retval = __real_fstatat(dirfd, path, info, flags);
if (retval == 0 && (flags & AT_SYMLINK_NOFOLLOW) && S_ISLNK(info->st_mode)) {
// POSIX requires a symlink's st_size to be the length of the target path.
// Android's /data filesystem reports a different value, so normalize it
// via readlink. Save and restore errno so a readlinkat failure doesn't
// pollute it while the call still reports success.
int saved_errno = errno;
char buf[PATH_MAX];
ssize_t len = readlinkat(dirfd, path, buf, sizeof(buf));
if (len >= 0) {
info->st_size = len;
}
errno = saved_errno;
}
return retval;
}

if (info == NULL) {
Expand Down
Loading