Skip to content

aosp: fix fstatat() calls for android asset paths#11212

Closed
rogerzanoni wants to merge 1 commit into
youtube:mainfrom
rogerzanoni:aosp-fstatat-fix
Closed

aosp: fix fstatat() calls for android asset paths#11212
rogerzanoni wants to merge 1 commit into
youtube:mainfrom
rogerzanoni:aosp-fstatat-fix

Conversation

@rogerzanoni

@rogerzanoni rogerzanoni commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Routes fstatat(AT_FDCWD, ..., flag == 0) for Android asset paths
through the __wrap_stat implementation.

Fixes the following issues in multiple tests:
asset_manager.cc: Asset path not found

Bug: 532068409

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🤖 Gemini Suggested Commit Message


android: Fix fstatat calls for asset paths

Update the Starboard modular POSIX layer to handle Android asset
paths during stat operations. Musl's stat implementation relies on
fstatat, which does not natively support asset paths. By routing
these calls through the Android-specific stat wrapper, asset
resolution is correctly maintained for modular builds.

Issue: 11212

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

@rogerzanoni rogerzanoni changed the title Fix fstatat() calls for android asset paths aosp: fix fstatat() calls for android asset paths Jul 12, 2026
@rogerzanoni
rogerzanoni marked this pull request as ready for review July 12, 2026 22:42

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies __abi_wrap_fstatat in starboard_layer_posix_stat_abi_wrappers.cc to route Android asset path stat calls through stat under specific conditions. The review feedback points out a typo in a comment and an outdated closing brace comment that does not match the actual conditional logic.

Comment thread starboard/shared/modular/starboard_layer_posix_stat_abi_wrappers.cc Outdated
Comment thread starboard/shared/modular/starboard_layer_posix_stat_abi_wrappers.cc Outdated
@rogerzanoni
rogerzanoni force-pushed the aosp-fstatat-fix branch 2 times, most recently from 81000e3 to 3548a49 Compare July 14, 2026 15:25
@sacuff
sacuff enabled auto-merge (squash) July 15, 2026 20:49
@sacuff
sacuff force-pushed the aosp-fstatat-fix branch from 3548a49 to f25051b Compare July 15, 2026 20:49
Routes fstatat(AT_FDCWD, ..., flag == 0) for Android asset paths
through the __wrap_stat implementation.

Fixes the following issues in multiple tests:
  asset_manager.cc: Asset path not found

Bug: 532068409
auto-merge was automatically disabled July 21, 2026 17:35

Head branch was pushed to by a user without write access

@andrewsavage1 andrewsavage1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this customization should happen in android's posix_emu directory instead of being across all platforms

@rogerzanoni

Copy link
Copy Markdown
Collaborator Author

Actually, already fixed by f2a15b9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants