aosp: fix fstatat() calls for android asset paths#11212
Closed
rogerzanoni wants to merge 1 commit into
Closed
Conversation
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
rogerzanoni
force-pushed
the
aosp-fstatat-fix
branch
from
July 7, 2026 17:50
c09a076 to
06ea1ec
Compare
rogerzanoni
force-pushed
the
aosp-fstatat-fix
branch
from
July 12, 2026 22:42
06ea1ec to
765b90e
Compare
rogerzanoni
marked this pull request as ready for review
July 12, 2026 22:42
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies __abi_wrap_fstatat in starboard_layer_posix_stat_abi_wrappers.cc to route Android asset path stat calls through stat under specific conditions. The review feedback points out a typo in a comment and an outdated closing brace comment that does not match the actual conditional logic.
rogerzanoni
force-pushed
the
aosp-fstatat-fix
branch
2 times, most recently
from
July 14, 2026 15:25
81000e3 to
3548a49
Compare
sacuff
approved these changes
Jul 15, 2026
sacuff
enabled auto-merge (squash)
July 15, 2026 20:49
Routes fstatat(AT_FDCWD, ..., flag == 0) for Android asset paths through the __wrap_stat implementation. Fixes the following issues in multiple tests: asset_manager.cc: Asset path not found Bug: 532068409
auto-merge was automatically disabled
July 21, 2026 17:35
Head branch was pushed to by a user without write access
rogerzanoni
force-pushed
the
aosp-fstatat-fix
branch
from
July 21, 2026 17:35
f25051b to
f39a4df
Compare
andrewsavage1
requested changes
Jul 23, 2026
andrewsavage1
left a comment
Contributor
There was a problem hiding this comment.
It looks like this customization should happen in android's posix_emu directory instead of being across all platforms
Collaborator
Author
|
Actually, already fixed by f2a15b9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routes fstatat(AT_FDCWD, ..., flag == 0) for Android asset paths
through the __wrap_stat implementation.
Fixes the following issues in multiple tests:
asset_manager.cc: Asset path not found
Bug: 532068409