Implemented the requested Blade theme for the Select component #349
Implemented the requested Blade theme for the Select component #349priyan923 wants to merge 7 commits into
Conversation
Added a new theme 'Blade' with specific classes and animation.
Added styles for blade theme in select component.
Updated theme to 'Blade' and removed background styles.
|
@priyan923 is attempting to deploy a commit to the younis' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| "class": "dyvix-select-blade", | ||
| "input-class": "dyvix-select-input-blade", | ||
| "dropdown-class": "dyvix-select-dropdown-blade", | ||
| "default-animation": "drift" |
There was a problem hiding this comment.
you need to separate Blade and Ember theme registries.
| <DyvixSelect | ||
| animation={DYVIX_GLOBAL_ANIMATION.GLITCH} | ||
| // theme={DYVIX_GLOBAL_THEME.SINGULARITY} | ||
| theme="Blade" // Using your new theme | ||
| placeholder={'number'} | ||
| background={'Red'} | ||
| dropdownBackground={'Red'} | ||
| // background and dropdownBackground removed to let the theme handle styles |
younisdev
left a comment
younisdev
left a comment
There was a problem hiding this comment.
@priyan923 I left a review please revise the pull request. Thanks in advance!
|
Okay @younisdev |
Removed comments about theme usage and style handling.
Added new theme 'Ember' with associated classes.
priyan923
left a comment
priyan923
left a comment
There was a problem hiding this comment.
@younisdev ,
I have made the required changes , you may check ,
Thanks
|
@priyan923 Thanks for the revision! The implementation works, but it still doesn't quite match the existing global |
2 participants
Closes #347
Changes:
src/components/select/dependencies/themes.jsonto include the Blade theme configuration, following the existing structure..dyvix-select-blade in src/components/select/dependencies/style/themes.css, modeling the approach after the Modal component's style implementation.devbench/src/component/select.jsxto allow for verification within the development workbench.