perf(errorMessagePrettifier): narrow regex match range#204
Merged
Conversation
kevinramharak
approved these changes
Apr 27, 2026
Collaborator
|
I think this is correct, the initial capture doesn't do anything besides causing backtracking once the later parts are matched. And the capture isn't transformed in the replacer function either. Doubt it will be noticeable, but it should technically reduce the work done, and remove another backtracking source in case any (highly unlikely) regex dos attempts are made. |
yoavbls
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #139
The
(.*)at the beginning of the regular expression onpackages/formatter/src/errorMessagePrettifier.ts#L128was matching characters that were passed through unchanged (just concatenated as-is to the output).pretty-ts-errors/packages/formatter/src/errorMessagePrettifier.ts
Line 128 in b1ca17d
In this PR, I improved inefficient matching by narrowing the match to cover only the portion that is actually transformed.