Feature: ensure scene settings at scene opening

[Tilix4]

Changelog Description

Ensure scene settings at file opening.

Additional review information

I don't know why this has been left commented. I believe @BigRoy may have some information.

Testing notes:

1. Open a scene
2. Change timeline duration, save and close
3. Open the same scene again, settings are restored.

[BigRoy]

I don't know why this has been left commented. I believe @BigRoy may have some information.

Unfortunately I don't. It's been like that for 2+ years it seems. Perhaps @iLLiCiTiT or @kalisp might remember why?

[kalisp]

We were adding menu option to set Settings explicitly instead of overwriting existing ones on launch. I think it was request from client as it was resetting artists overrides (for lead-in or preroll animation), afaik.
(I am not sure now if it was Harmony on AE though.)

Maybe this could be controllable by Settings?

Located this notice:

* OP-5466 - do not force settings from DB

Added separate menu item to set frames and resolution from DB to scene.

Another note:

Customer stores turntable frames after scene end frames. Only scene frames should be rendered, but turntable frames should be kept intact.
``

Not sure if I can locate that issue description.

[BigRoy]

Essentially, this ensure settings should only apply on app launch, but NOT to existing scenes (e.g. opened last workfile) but only apply to empty scenes.

It should NOT change scenes on open.

So maybe I guess it did do that previously, and that's why it got commented out?

[Tilix4]

this ensure settings should only apply on app launch

Currently I don't witness this behaviour, scene settings are never auto applied for no any scene, even empty ones. Where does this logic takes place?

It should NOT change scenes on open.

I don't understand why that prerequisite is mandatory. What if the shot's frame timing is changed in Ayon? I'd like it to be changed automatically without the artist having to open the shot, failing on validate, repair and publish again.

However, I understand that this behaviour should be configurable depending on the workflow. Would you approve if I'd introduce a setting to trigger this automatically?

[BigRoy]

I don't understand why that prerequisite is mandatory. What if the shot's frame timing is changed in Ayon? I'd like it to be changed automatically without the artist having to open the shot, failing on validate, repair and publish again.

However, I understand that this behaviour should be configurable depending on the workflow. Would you approve if I'd introduce a setting to trigger this automatically?

By default new scenes should auto-apply with the correct startup settings (if that's not the case now, we should fix it). On scene open, we should not be enforcing scene changes. It gives the false notion that what you're opening was left in that state + it leaves you essentially unable to open the original file.

The common approach in AYON is for these scenarios upon opening file (and sometimes on file save as well) to prompt the user that some scene settings mismatch the current context, with the ability to decide to reset or not the relevant attributes so the user can skip it if needed.

Nuke integration is suffering from this massively. On scene open it enforces the current context settings, meaning that sometimes a week later an artist opens there scene and it behaves completely different because e.g. FPS was changed or the frame range. Or even in certain scenarios the same would happen on headless scenarios (which I think was patched recently.)

It should really prompt user in GUI mode, and log warning in headless mode.
Whether a setting is worth it to enforce applying without prompt - I'm happy to have the argument, but I've seen the nasty side effects of it from the Nuke integration.

[Tilix4]

By default new scenes should auto-apply with the correct startup settings (if that's not the case now, we should fix it). On scene open, we should not be enforcing scene changes. It gives the false notion that what you're opening was left in that state + it leaves you essentially unable to open the original file.

I confirm it is not set for new scenes. I can fix it in in the current PR, but I'm not sure how to reliably check this is a new scene, is the regular way to check the scene is not a saved Ayon workfile?

It should really prompt user in GUI mode, and log warning in headless mode. Whether a setting is worth it to enforce applying without prompt - I'm happy to have the argument, but I've seen the nasty side effects of it from the Nuke integration.

Fine, I agree that auto-modifying the workfile must prompt a message to the artist and let them decide. I'll go this way.

[kalisp]

Just marking this as requiring changes mentioned in last comments.