refactor: remove jQuery, SweetAlert, Bootstrap; extract tags data#172
Merged
Conversation
- Remove jQuery from traininglist, traindetails, paintboard (native DOM) - Remove SweetAlert from traininglist (use vscode notification via postMessage) - Remove Bootstrap 3.3.7 CSS/JS from paintboard - Remove CDN dependencies from paintboard (inline all resources) - Replace jQuery UI draggable with native mouse drag implementation - Replace alert() with vscode.postMessage in paintboard - Extract 2688-line tags data from shared.ts to src/data/tags.json - Remove jquery, @types/jquery, @types/dateformat from package.json - Delete unused resource files: jquery.min.js, sweetalert-dev.js, sweetalert.css, bootstrap.min.js, bootstrap.min.css - Remove href='javascript:void(0)' anti-pattern - Replace deprecated HTML attributes (nowrap, align, border) with CSS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of PR #171 — deep cleanup of deprecated libraries and legacy code.
Removed libraries
Deleted resource files
resources/jquery.min.js(69KB)resources/sweetalert-dev.js(50KB)resources/sweetalert.css(17KB)resources/bootstrap.min.js(37KB)resources/bootstrap.min.css(119KB)Total: ~292KB of bundled resources removed.
Tags data extraction
src/utils/shared.tstosrc/data/tags.jsonshared.tsreduced from 3160 lines to 472 linesCode modernization
href=javascript:void(0)anti-patternnowrap,align,border) with CSSonmouseout/onmouseoverhandlers with CSS:hover.draggable()with nativemousedown/mousemove/mouseupalert()withvscode.postMessagefor proper VSCode notification handlingTest results