Remove yk_promote from MP_BC_LOAD_CONST_OBJ.#17
Closed
Pavel-Durov wants to merge 1 commit into
Closed
Conversation
Calling yk_promote() in MP_BC_LOAD_CONST_OBJ adds runtime overhead of ~30% on AWFY List benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
yk_promotefromMP_BC_LOAD_CONST_OBJCalling
yk_promoteatMP_BC_LOAD_CONST_OBJadds overhead on every bytecode constant load. This PR removes it.perf diff
__yk_opt_gc_allocmp_execute_bytecodeRuntime accounting
Time in
__yk_opt_gc_allocTime in
mp_execute_bytecodeConclusion:
__yk_opt_gc_allocaccounts for almost 100% of the runtime regressionmp_execute_bytecodeshows a diff in perf (6.8% vs 9.75%) but theabsolute time is the same (~2s each)