chore: merge changes into 1.2.x#617
Closed
jwartofsky-yext wants to merge 3 commits into
Closed
Conversation
> Summary > Using variable interpolation $... with github context data in a run: step could allow an attacker to inject their own code into the runner. This would allow them to steal secrets and code. github context data can have arbitrary user input and should be treated as untrusted. Instead, use an intermediate environment variable with env: to store the data and use the environment variable in the run: script. Be sure to use double-quotes the environment variable, like this: "$ENVVAR".
This recursively updates minimatch so all downstream dependencies are using secure versions. https://nvd.nist.gov/vuln/detail/CVE-2026-27903 A newer version of `@microsoft/api-extractor` was also required since the old one used an insecure version of minimatch, but this introduced issues caused by inconsistent TypeScript versions. I upgraded TypeScript, node, and glob, to get everything working again. Also upgraded playwright as I was seeing Github actions hang on the browser install step, which has been fixed in 1.60.0. microsoft/playwright#40998 --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
After running "npm run build -- --reverse-proxy-prefix=www.brand.com/locations", I see these files modified: **vite.config.ts** ``` import { defineConfig } from "vite"; import react from "@vitejs/plugin-react"; import yextSSG from "@yext/pages/vite-plugin"; import { yextVisualEditorPlugin } from "@yext/visual-editor/plugin" export default defineConfig({ plugins: [react(), yextVisualEditorPlugin(), yextSSG()], build: { assetsDir: "locations/assets" } }); ``` **config.yaml** ``` buildConfiguration: buildCommand: npm run build installDependenciesStep: command: npm install requiredFiles: - package.json - package-lock.json - .npmrc livePreviewConfiguration: setupCommand: ":" sitemap: excludeList: - edit serving: reverseProxyPrefix: www.brand.com/locations dynamicRoutes: - from: /assets/* to: /locations/assets/:splat status: 200 ``` The **dist/assets** are also updated: <img width="211" height="268" alt="image" src="https://github.com/user-attachments/assets/226d213e-81f2-4795-baa5-fb2a8ee7bf28" /> See example of a run here: YextSolutions/pages-visual-editor-starter#330
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jwartofsky-yext
requested review from
asanehisa,
benlife5,
briantstephan and
mkilpatrick
mkilpatrick
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges the following changes into the 1.2.x branch
118eae1 (HEAD -> main, origin/main, origin/HEAD) feat: add reverse-proxy-prefix option to build (#616)
8ba6b60 chore: update minimatch (#614)
9bc82e0 chore: prevent shell injection in github action (vuln-44057) (#613)