You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR bumps the pnpm.overrides pin for axios from 1.15.0 to 1.16.0 in package.json, updates @playwright/test and playwright-core devDependency versions in two package.json files to ^1.60.0, and adjusts the Markdown list formatting for the “Coming Soon” HoursStatus/HoursTable entry in packages/pages-components/CHANGELOG.md.
The title 'fix: force secure version of axios' directly and accurately summarizes the main change: updating axios to version 1.16.0 to address a security vulnerability.
Linked Issues check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Description check
✅ Passed
The description directly explains the security fix for axios vulnerability and an unrelated Playwright upgrade to fix CI hangs.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches🧪 Generate unit tests (beta)
Create PR with unit tests
Commit unit tests in branch axios-vulnerability
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that axios version 1.16.0 is used, which avoids the following vulnerability present in 1.15.0.
GHSA-pjwm-pj3p-43mv
Also upgraded playwright as I was seeing Github actions hang on the browser install step, which has been fixed in 1.60.0.
microsoft/playwright#40998