test

[yet300]

Summary

• Audit + 165 unit tests across core:domain, core:data, core:common,
  feature:{home, settings, game, root} — every test green on
  iosSimulatorArm64Test.
• Extracted Firebase telemetry into a new core:telemetry module so
  core:data no longer pulls Firebase into iOS test linking. TelemetryBindings
  is wired into both AndroidAppGraph and NativeAppGraph, so runtime DI
  is unchanged.
• Moved the pure formatScore utility to core:common so it's reachable from
  shared test sources.
• New CI workflow runs ./gradlew allTests on macOS PRs and a Linux
  assembleDebug smoke check; the existing release pipeline is untouched.

What's covered

Layer	Module	Tests
Pure logic	core:common (FormatScore)	7
Pure logic	core:domain (Score, Grid, ShapeGenerator, GameEngine)	62
Repositories	core:data (GameSave, Settings, Audio, Vibration)	27
Stores	feature:home HomeStoreFactory + Mappers	9
Stores	feature:settings SettingsStoreFactory + Mappers	7
Stores	feature:game GameStoreFactory	24
Components	feature:home DefaultHomeComponent	5
Components	feature:settings DefaultMainSettingsComponent	6
Components	feature:game DefaultGameComponent + ReviewPrompt	9
Components	feature:root DefaultRootComponent	8
Total		165

Edge cases covered include cross-clear scoring, combo multiplier chain,
game-over detection without false-positives on row/col completion,
revive caps, autosave debounce, save-restore JSON corruption,
monotonic best-score, concurrent review-counter increments,
audio music gating across requested && foreground && enabled,
review-prompt qualifier matrix (min score / delta / max / per-round),
game-over countdown edge-trigger, and lifecycle bg/fg → audio bridge.

Architecture changes

• New module core:telemetry — CrashlyticsRepositoryImpl,
  AnalyticRepositoryImpl, and their @Binds declarations moved out of
  core:data. composeApp depends on the new module directly; core:data
  no longer references Firebase.
• formatScore → core:common — pure utility, easier to test, no logic
  change.

Both are surface-level moves with no behavioural impact; production iOS and
Android telemetry continues to work via the same AppScope DI graph.

CI

.github/workflows/ci.yml:

• tests on macos-15 — needed for iosSimulatorArm64 test runner.
  Uploads HTML test reports as an artifact on failure (7-day retention).
• android-build on ubuntu-latest — :androidApp:assembleDebug smoke check.
• Concurrency: in-flight PR runs cancel on new commits; main pushes do not.

Out of scope (flagged at audit, deferred)

• Compose UI tests for the Game screen — needs a UI-test runner module
  or a JVM/desktop target; can be added separately if desired.
• Three minor inline cleanups noticed during audit (separate PRs):
  • pieceIdCounter not reset in GameEngine.restore (potential id collision
    after revive on a restored save)
  • Loop of incrementReviewPromptCount() in
    DefaultGameComponent.onReviewPromptDontShowAgainClicked — could be a
    single set operation
  • Unused storeReview constructor parameter in GameStoreFactory

Test plan

• ./gradlew allTests — 165 tests, 0 failures, locally on macOS
• ./gradlew :composeApp:linkDebugFrameworkIosSimulatorArm64 — iOS prod
  framework links
• ./gradlew :androidApp:assembleDebug — Android release-shell builds
• CI green on this PR (will verify once opened)