Fix sound button duplication#136
Open
abhiram-shaji wants to merge 128 commits into
Open
Conversation
added MIT license
* Added About, Getting Started, Prerequisites, Installation, Contributing
updated README.md
Added a snapshot of the UI
Updated Readme
added google analytics
doc:Updated README.md and contribution files
Added .gitignore
changes in border of style container
…ing_MiniMax_Algorithm Add Computer Moves using MiniMax Algorithm
New Dark Mode + General Fixes
Fixed Issue yelynn1#41 including an improvement on the appearance of the About Page
fixed collapsed nav bar
Updated dark mode more holistically and toggle for Light and Dark
Feature/volume slider
added a how to play guide
…rn-off-the-sounds-at-the-end-of-the-game adding a new feature : a button to mute sounds at the end of the game
added change directory command
Add 2 Player support
abhiram-shaji
force-pushed
the
fix-sound-button-duplication
branch
from
6022057 to
28bec2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sound Button Duplication #132
If you win the game and undo the last move, then win again, the sound button duplicates itself.
Solution
The solution involves modifying the
checkWinnerfunction to check if the sound button already exists before creating a new one. This prevents the duplication of the sound button.