revert: drop fish completions (#251) — avoid host completion install#252
Merged
Conversation
…nstall Reverts #251. Shell Tab completion fundamentally requires a completion file in the shell's completion path on the host; the maintainer does not want that host footprint for the dev flow, and it does not fit the repo's usage model. Flags remain discoverable with zero install via `just tui --help` / `setup_ubuntu --help`. Removes the four .fish files, the bats spec, the .gitignore allow-list lines, and the CHANGELOG entry. Claude-Session: https://claude.ai/code/session_01NX5H2vuMTv4mBmjpPYoS3s Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #251 (fish completions). Tab completion inherently needs a completion
file installed into the shell's completion path on the host; the maintainer does
not want that host footprint for the dev flow and it does not fit the repo's
usage model. Flags stay discoverable with zero install via
just tui --help/setup_ubuntu --help.Removes the four
.fishfiles,test/unit/fish_completions_spec.bats, the.gitignoreallow-list lines, and the CHANGELOG entry.Test plan
completions remain;
.gitignorerestored to its prior 2 negations.Generated with Claude Code.