-
Notifications
You must be signed in to change notification settings - Fork 37
fix: banner for usage alert #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add
role="status"to the banner for screen reader accessibility.The banner is a time-sensitive notification that should be announced to assistive technology users. Adding
role="status"(orrole="alert"for more urgent announcements) ensures screen readers pick it up.♿ Proposed accessibility fix
📝 Committable suggestion
🤖 Prompt for AI Agents
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Banner position doesn't adapt to
bannerVisiblestate — causes a 44px gap when the countdown banner is hidden.The amber banner is hardcoded to
top-[114px], but the existing mobile menu overlay (line 255) already adjusts betweentop-[114px] sm:top-[110px](whenbannerVisibleis true) andtop-[70px](when false). WhenBetaCountdownBanneris not visible, the header is only 70px tall, leaving a visible gap between the header and the amber banner.Use
bannerVisibleto dynamically set the banner'stopoffset, and usecn()from@/lib/utilsfor the conditional classes as per coding guidelines.🐛 Proposed fix for dynamic banner positioning
📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Coding guidelines
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Add a dismiss mechanism for the temporary outage banner.
The banner is a temporary notification about Opus being down, but there's no way for users to dismiss it. This forces the banner to persist on screen indefinitely, degrading the user experience. Consider adding a close button with local state (or a server-driven flag) to allow dismissal.
♻️ Suggested dismiss button implementation
🤖 Prompt for AI Agents