Skip to content

Remove stats.json#6653

Merged
BYK merged 1 commit into
yarnpkg:masterfrom
mayflower:remove-stats
Nov 12, 2018
Merged

Remove stats.json#6653
BYK merged 1 commit into
yarnpkg:masterfrom
mayflower:remove-stats

Conversation

@lheckemann

Copy link
Copy Markdown
Contributor

Remove stats.json which shouldn't be there as far as I can tell.

Seems to be some sort of IDE metadata erroneously introduced in
7ff626c (#5934)

cc @BYK who added this

Seems to be some sort of IDE metadata erroneously introduced in
7ff626c (yarnpkg#5934)
@buildsize

buildsize Bot commented Nov 8, 2018

Copy link
Copy Markdown
File name Previous Size New Size Change
yarn-[version].noarch.rpm 1.1 MB 1.09 MB -13.94 KB (1%)
yarn-[version].js 4.46 MB 4.27 MB -197.74 KB (4%)
yarn-legacy-[version].js 4.65 MB 4.44 MB -216.68 KB (5%)
yarn-v[version].tar.gz 1.12 MB 1.1 MB -19.22 KB (2%)
yarn_[version]all.deb 813.67 KB 804.48 KB -9.19 KB (1%)

@Gudahtt Gudahtt requested a review from BYK November 8, 2018 23:37

@BYK BYK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch!

@lheckemann

Copy link
Copy Markdown
Contributor Author

Would this auto-merge if the test hadn't failed? The failure is unrelated to my change AFAICT.

@BYK

BYK commented Nov 12, 2018

Copy link
Copy Markdown
Member

It won't auto merge and I agree it seems completely unrelated. Restarted the job to make sure tho.

@BYK

BYK commented Nov 12, 2018

Copy link
Copy Markdown
Member

I think that item is broken altogether on around this specific commit:

node@10 is keg-only, which means it was not symlinked into /usr/local,
because this is an alternate version of another formula.

If you need to have node@10 first in your PATH run:
  echo 'export PATH="/usr/local/opt/node@10/bin:$PATH"' >> ~/.bash_profile

For compilers to find node@10 you may need to set:
  export LDFLAGS="-L/usr/local/opt/node@10/lib"
  export CPPFLAGS="-I/usr/local/opt/node@10/include"

Gonna merge myself.

@BYK BYK merged commit 9049e6e into yarnpkg:master Nov 12, 2018
@lheckemann lheckemann deleted the remove-stats branch November 13, 2018 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants