Fix missing self-contained header includes#238
Merged
Conversation
Some stricter build environments require every public header to be self-contained. In other words, including and compiling any public header on its own must not depend on another header having happened to be included first. `SegmentTagged.hpp` previously worked under the common include paths used in this repository, but it did not declare `DictTrie` when compiled in isolation. Similarly, `HMMSegment.hpp` indirectly depended on `DictTrie.hpp` for `MIN_DOUBLE`. These implicit include dependencies can become real build failures when using stricter header parsing, modular builds, PCH/IWYU workflows, or simply a different include order. Add the missing direct includes so the affected headers are self-contained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some stricter build environments require every public header to be self-contained. In other words, including and compiling any public header on its own must not depend on another header having happened to be included first.
SegmentTagged.hpppreviously worked under the common include paths used in this repository, but it did not declareDictTriewhen compiled in isolation. Similarly,HMMSegment.hppindirectly depended onDictTrie.hppforMIN_DOUBLE.These implicit include dependencies can become real build failures when using stricter header parsing, modular builds, PCH/IWYU workflows, or simply a different include order. Add the missing direct includes so the affected headers are self-contained.