Воронина Веда @Vedochka - #9
Open
Veda345 wants to merge 2 commits into
Open
Conversation
Ideas for improvements: 1) deal with wrong arguments (2 and more match_parent) 2) ability of setting layout_gravity
Collaborator
|
Всё хорошо
|
| // frame within its container. | ||
| Gravity.apply(lp.gravity, width, height, mTmpContainerRect, mTmpChildRect); | ||
|
|
||
| // Place the child. |
Collaborator
There was a problem hiding this comment.
Это, конечно, лично мое мнение, но и без комментариев очевидно, что происходит) обычно их не используют слишком часто, так как сложно поддерживать
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Viable custom layout.
Ideas for improvements:
Первый и третий элемент - wrap_content, второй - match_parent, четвертый - fixed size.