Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getPageStatsByUrlto parse a full URL into the actual Umami stats filters (path+hostname) instead of sending the ignoredurlquery parameter.hostnamesupport to stats query parameters and expandedMetricTypeto match the currently documented Umami v2 metric types (entry,exit,query,channel,domain,hostname,distinctId, etc.).querymetric type and widening metric values tostring | null, matching observed self-hostedtype=queryresponses.Review & Testing Checklist for Human
getPageStatsByUrl('https://your-domain/path?query=...')returns page-specific stats on your own Umami share link, especially when one website tracks multiple hostnames.options.pathwithgetPageStatsByUrldo not rely on overriding the parsed path; the method now intentionally prioritizes the URL-derived path/hostname.getPageStatsByUrlagainst the same path in the Umami UI.Notes
cloud.umami.is/analytics/us/share/pNrbzntfHm1jet1fand self-hostedumami.14131413.xyz/share/JsbYvsDKnsLboth ignoreurl=on/stats;path=filters correctly, andhostname=further narrows multi-host self-hosted data.type=queryreturns 200 on both provided endpoints; self-hosted can return{ x: null, y: ... }.pnpm test,pnpm exec tsc --noEmit,pnpm build.