chore: Migrate to uv; Bump required Python version to 3.14.#66
Open
junhaoliao wants to merge 1 commit into
Open
chore: Migrate to uv; Bump required Python version to 3.14.#66junhaoliao wants to merge 1 commit into
junhaoliao wants to merge 1 commit into
Conversation
WalkthroughThis PR migrates the docs tooling to Changesuv migration for docs tooling
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@taskfiles/deps/lock.yaml`:
- Around line 4-19: The user-facing tasks check-uv and update-uv in the task
definition should have descriptions so they show up clearly in task --list. Add
a concise desc: entry to each of these task definitions, keeping uv-lock
unchanged since it is internal, and use the task names as the identifying
anchors when updating the taskfile.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 23573a49-f953-42e6-87fc-e01a88aa559c
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (7)
README.mdpyproject.tomlrequirements.txttaskfile.yamltaskfiles/deps/lock.yamltaskfiles/deps/main.yamltaskfiles/docs.yaml
💤 Files with no reviewable changes (1)
- requirements.txt
8f47ff2 to
0f9ebb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate the docs taskchain from
requirements.txt+ ad-hoc venv bootstrap to UV-driven dependency management with behavior aligned to existing CLP/YScope task patterns.Key updates:
[project]and[tool.uv]) and replaced Python dependency source fromrequirements.txtwithpyproject.toml+uv.lockreferences in venv task sourcing.uv run --directory "{{.ROOT_DIR}}" --lockedand kept venv inbuild/venv.uv.requirements.txtfrom docs dependency bootstrapping, added UV lock metadata refresh.Checklist
Validation performed
Scenario 1: Verify modified task surface
Task: Ensure task discovery reflects updated and added uv tasks.
Command:
Output:
Explanation: confirms new lock tasks are present via the new
taskfiles/depsinclude.Scenario 2: Validate docs build path
Task:
docs:build(build+symlink path and dependency gating).Command:
Output:
Scenario 3: Validate docs clean target
Task:
docs:cleanCommand:
Output:
Scenario 4: Validate project-docs download via UV runtime
Task:
docs:download-projectsCommand:
Output:
Scenario 5: Validate UV lock check/update tasks
Task:
deps:lock:check-uvanddeps:lock:update-uvCommand:
Output:
Scenario 6: Validate release tar path after migration
Task:
docs:release-tarCommand:
Output:
Scenario 7: Validate docs serve path (expected timeout while host is live)
Task:
docs:servewith 25s timeout wrapperCommand:
Output:
Explanation: Serve command was expected to run continuously; timeout 25s terminates it once startup succeeded.
Summary by CodeRabbit
New Features
uvwith locked inputs.Chores
pyproject.tomlfor project metadata and documentation dependencies.uvand adjusted the listed Python prerequisites.uvlockfiles.