-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Add CLP connector. #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e934611
0977d33
7fb6309
e4a54a6
b0e5211
b05bba5
6e36614
46754a1
e74745d
85acfe0
864519c
0686e0f
e9f9046
f965510
741e8b3
cf58de1
82a1a91
dc3d9f8
bd1cefc
952a58d
453af87
74f63ce
d249799
9411387
f3b0576
e4f5b39
01b51dd
01d8efa
17fc6e4
b10d1aa
a65d818
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,36 @@ | ||||||||||||||||||||
| # Copyright (c) Facebook, Inc. and its affiliates. | ||||||||||||||||||||
| # | ||||||||||||||||||||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||||||||||||||||||||
| # you may not use this file except in compliance with the License. | ||||||||||||||||||||
| # You may obtain a copy of the License at | ||||||||||||||||||||
| # | ||||||||||||||||||||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||||||||||||||||||||
| # | ||||||||||||||||||||
| # Unless required by applicable law or agreed to in writing, software | ||||||||||||||||||||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||||||||||||||||||||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||||||||||||||||
| # See the License for the specific language governing permissions and | ||||||||||||||||||||
| # limitations under the License. | ||||||||||||||||||||
| include_guard(GLOBAL) | ||||||||||||||||||||
|
|
||||||||||||||||||||
| set(VELOX_ANTLR4_RUNTIME_VERSION 4.13.2) | ||||||||||||||||||||
| set(VELOX_ANTLR4_RUNTIME_BUILD_SHA256_CHECKSUM | ||||||||||||||||||||
| 9f18272a9b32b622835a3365f850dd1063d60f5045fb1e12ce475ae6e18a35bb) | ||||||||||||||||||||
| set(VELOX_ANTLR4_RUNTIME_SOURCE_URL | ||||||||||||||||||||
| "https://github.com/antlr/antlr4/archive/refs/tags/${VELOX_ANTLR4_RUNTIME_VERSION}.tar.gz" | ||||||||||||||||||||
| ) | ||||||||||||||||||||
|
|
||||||||||||||||||||
| velox_resolve_dependency_url(ANTLR4_RUNTIME) | ||||||||||||||||||||
|
|
||||||||||||||||||||
| message(STATUS "Building antlr4-runtime from source") | ||||||||||||||||||||
|
|
||||||||||||||||||||
| FetchContent_Declare( | ||||||||||||||||||||
| antlr4-runtime | ||||||||||||||||||||
| URL ${VELOX_ANTLR4_RUNTIME_SOURCE_URL} | ||||||||||||||||||||
| URL_HASH ${VELOX_ANTLR4_RUNTIME_BUILD_SHA256_CHECKSUM} | ||||||||||||||||||||
| SOURCE_SUBDIR runtime/Cpp OVERRIDE_FIND_PACKAGE) | ||||||||||||||||||||
|
Comment on lines
+28
to
+31
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
CMake ≥ 3.24 requires the hash value to be prefixed with the algorithm (e.g., FetchContent_Declare(
antlr4-runtime
URL ${VELOX_ANTLR4_RUNTIME_SOURCE_URL}
- URL_HASH ${VELOX_ANTLR4_RUNTIME_BUILD_SHA256_CHECKSUM}
+ URL_HASH SHA256=${VELOX_ANTLR4_RUNTIME_BUILD_SHA256_CHECKSUM}
SOURCE_SUBDIR runtime/Cpp OVERRIDE_FIND_PACKAGE)📝 Committable suggestion
Suggested change
🤖 Prompt for AI AgentsThere was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. agree. Our min CMaker version is 3.28, so this might be an issue There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @anlowee Thank you for confirming! The If you found this review helpful, would you consider giving us a shout-out on X? Thank you for using CodeRabbit! |
||||||||||||||||||||
|
|
||||||||||||||||||||
| set(ANTLR4_INSTALL | ||||||||||||||||||||
| ON | ||||||||||||||||||||
| CACHE BOOL "" FORCE) | ||||||||||||||||||||
| FetchContent_MakeAvailable(antlr4-runtime) | ||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,44 @@ | ||||||||||||||
| # Copyright (c) Facebook, Inc. and its affiliates. | ||||||||||||||
| # | ||||||||||||||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||||||||||||||
| # you may not use this file except in compliance with the License. | ||||||||||||||
| # You may obtain a copy of the License at | ||||||||||||||
| # | ||||||||||||||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||||||||||||||
| # | ||||||||||||||
| # Unless required by applicable law or agreed to in writing, software | ||||||||||||||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||||||||||||||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||||||||||
| # See the License for the specific language governing permissions and | ||||||||||||||
| # limitations under the License. | ||||||||||||||
| include_guard(GLOBAL) | ||||||||||||||
|
|
||||||||||||||
| FetchContent_Declare( | ||||||||||||||
| clp | ||||||||||||||
| GIT_REPOSITORY https://github.com/y-scope/clp.git | ||||||||||||||
| GIT_TAG 0798100389bd5231b520ec48ab186275795e3790) | ||||||||||||||
|
|
||||||||||||||
| set(CLP_BUILD_CLP_REGEX_UTILS | ||||||||||||||
| OFF | ||||||||||||||
| CACHE BOOL "Build CLP regex utils") | ||||||||||||||
| set(CLP_BUILD_CLP_S_JSONCONSTRUCTOR | ||||||||||||||
| OFF | ||||||||||||||
| CACHE BOOL "Build CLP-S JSON constructor") | ||||||||||||||
| set(CLP_BUILD_CLP_S_REDUCER_DEPENDENCIES | ||||||||||||||
| OFF | ||||||||||||||
| CACHE BOOL "Build CLP-S reducer dependencies") | ||||||||||||||
| set(CLP_BUILD_CLP_S_SEARCH_SQL | ||||||||||||||
| OFF | ||||||||||||||
| CACHE BOOL "Build CLP-S search SQL") | ||||||||||||||
| set(CLP_BUILD_EXECUTABLES | ||||||||||||||
| OFF | ||||||||||||||
| CACHE BOOL "Build CLP executables") | ||||||||||||||
| set(CLP_BUILD_TESTING | ||||||||||||||
| OFF | ||||||||||||||
| CACHE BOOL "Build CLP tests") | ||||||||||||||
|
|
||||||||||||||
| FetchContent_Populate(clp) | ||||||||||||||
|
|
||||||||||||||
| list(APPEND CMAKE_MODULE_PATH "${clp_SOURCE_DIR}/components/core/cmake/Modules") | ||||||||||||||
| add_subdirectory(${clp_SOURCE_DIR}/components/core | ||||||||||||||
| ${clp_BINARY_DIR}/components/core) | ||||||||||||||
|
Comment on lines
+40
to
+44
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) optional: switch to
-FetchContent_Populate(clp)
-
-list(APPEND CMAKE_MODULE_PATH "${clp_SOURCE_DIR}/components/core/cmake/Modules")
-add_subdirectory(${clp_SOURCE_DIR}/components/core
- ${clp_BINARY_DIR}/components/core)
+FetchContent_MakeAvailable(clp)(Your cache-variable overrides are set before the call, so they still propagate.) 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # Copyright (c) Facebook, Inc. and its affiliates. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| include_guard(GLOBAL) | ||
|
|
||
| set(VELOX_DATE_BUILD_VERSION 3.0.1) | ||
| set(VELOX_DATE_BUILD_SHA256_CHECKSUM | ||
| 7a390f200f0ccd207e8cff6757e04817c1a0aec3e327b006b7eb451c57ee3538) | ||
| set(VELOX_DATE_SOURCE_URL | ||
| "https://github.com/HowardHinnant/date/archive/refs/tags/v${VELOX_DATE_BUILD_VERSION}.tar.gz" | ||
| ) | ||
|
|
||
| velox_resolve_dependency_url(DATE) | ||
|
|
||
| # Optionally set CMake variables *before* make-available | ||
| set(CMAKE_INSTALL_MESSAGE | ||
| LAZY | ||
| CACHE STRING "" FORCE) | ||
|
Comment on lines
+26
to
+28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Global override of Forcing 🤖 Prompt for AI AgentsThere was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. agree There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @anlowee Thanks for confirming—glad we’re aligned. Let me know if you’d like any help scoping that 🧠 Learnings used |
||
|
|
||
| message(STATUS "Building date from source") | ||
|
|
||
| FetchContent_Declare( | ||
| date | ||
| URL ${VELOX_DATE_SOURCE_URL} | ||
| URL_HASH ${VELOX_DATE_BUILD_SHA256_CHECKSUM} | ||
| OVERRIDE_FIND_PACKAGE) | ||
|
Comment on lines
+32
to
+36
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. URL_HASH is missing the required algorithm prefix ( CMake expects the FetchContent_Declare(
date
URL ${VELOX_DATE_SOURCE_URL}
- URL_HASH ${VELOX_DATE_BUILD_SHA256_CHECKSUM}
+ URL_HASH SHA256=${VELOX_DATE_BUILD_SHA256_CHECKSUM}
OVERRIDE_FIND_PACKAGE)🤖 Prompt for AI AgentsThere was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. agree There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @anlowee Thanks for confirming! You're absolutely right - the URL_HASH does need the SHA256= prefix for proper checksum validation. This will help ensure the integrity of the downloaded date library dependency. ✏️ Learnings added
If you found this review helpful, would you consider giving us a shout-out on X? Thank you for using CodeRabbit!
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. velox_resolve_dependency adds SHA256. Manually adding it will result in errors There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
| FetchContent_MakeAvailable(date) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # Copyright (c) Facebook, Inc. and its affiliates. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| include_guard(GLOBAL) | ||
|
|
||
| set(VELOX_MSGPACK_BUILD_VERSION cpp-7.0.0) | ||
| set(VELOX_MSGPACK_BUILD_SHA256_CHECKSUM | ||
| 070881ebea9208cf7e731fd5a46a11404025b2f260ab9527e32dfcb7c689fbfc) | ||
| set(VELOX_MSGPACK_SOURCE_URL | ||
| "https://github.com/msgpack/msgpack-c/archive/refs/tags/${VELOX_MSGPACK_BUILD_VERSION}.tar.gz" | ||
| ) | ||
|
|
||
| velox_resolve_dependency_url(MSGPACK) | ||
|
|
||
| message(STATUS "Building msgpack-cxx from source") | ||
|
Comment on lines
+23
to
+25
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Status message may be misleading after URL override.
Consider printing the message only when the resolver decided to build from 🤖 Prompt for AI Agents |
||
|
|
||
| FetchContent_Declare( | ||
| msgpack-cxx | ||
| URL ${VELOX_MSGPACK_SOURCE_URL} | ||
| URL_HASH ${VELOX_MSGPACK_BUILD_SHA256_CHECKSUM} | ||
| OVERRIDE_FIND_PACKAGE EXCLUDE_FROM_ALL SYSTEM) | ||
|
|
||
| set(MSGPACK_USE_BOOST OFF) | ||
|
|
||
| FetchContent_MakeAvailable(msgpack-cxx) | ||
|
Comment on lines
+27
to
+35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Expose an imported target for downstream linking convenience. Many third-party projects expect to link against an Add: # Ensure an ALIAS exists at the top level.
if (NOT TARGET msgpackc::msgpackc AND TARGET msgpackc)
add_library(msgpackc::msgpackc ALIAS msgpackc)
endif()This small alias spares every dependent Velox component from writing custom 🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # Copyright (c) Facebook, Inc. and its affiliates. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| include_guard(GLOBAL) | ||
|
|
||
| set(VELOX_NLOHMANN_JSON_BUILD_VERSION 3.11.3) | ||
| set(VELOX_NLOHMANN_JSON_BUILD_SHA256_CHECKSUM | ||
| 0d8ef5af7f9794e3263480193c491549b2ba6cc74bb018906202ada498a79406) | ||
| set(VELOX_NLOHMANN_JSON_SOURCE_URL | ||
| "https://github.com/nlohmann/json/archive/refs/tags/v${VELOX_NLOHMANN_JSON_BUILD_VERSION}.tar.gz" | ||
| ) | ||
|
|
||
| velox_resolve_dependency_url(NLOHMANN_JSON) | ||
|
|
||
| message(STATUS "Building nlohmann_json from source") | ||
|
|
||
| FetchContent_Declare( | ||
| nlohmann_json | ||
| URL ${VELOX_NLOHMANN_JSON_SOURCE_URL} | ||
| URL_HASH ${VELOX_NLOHMANN_JSON_BUILD_SHA256_CHECKSUM} | ||
| OVERRIDE_FIND_PACKAGE) | ||
|
|
||
| set(JSON_BuildTests | ||
| OFF | ||
| CACHE INTERNAL "") | ||
|
|
||
| FetchContent_MakeAvailable(nlohmann_json) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # Copyright (c) Facebook, Inc. and its affiliates. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| include_guard(GLOBAL) | ||
|
|
||
| set(VELOX_SPDLOG_BUILD_VERSION 1.12.0) | ||
| set(VELOX_SPDLOG_BUILD_SHA256_CHECKSUM | ||
| 4dccf2d10f410c1e2feaff89966bfc49a1abb29ef6f08246335b110e001e09a9) | ||
| set(VELOX_SPDLOG_SOURCE_URL | ||
| "https://github.com/gabime/spdlog/archive/refs/tags/v${VELOX_SPDLOG_BUILD_VERSION}.tar.gz" | ||
| ) | ||
|
|
||
| velox_resolve_dependency_url(SPDLOG) | ||
|
|
||
| message(STATUS "Building spdlog from source") | ||
|
|
||
| FetchContent_Declare( | ||
| spdlog | ||
| URL ${VELOX_SPDLOG_SOURCE_URL} | ||
| URL_HASH ${VELOX_SPDLOG_BUILD_SHA256_CHECKSUM} | ||
| OVERRIDE_FIND_PACKAGE EXCLUDE_FROM_ALL SYSTEM) | ||
|
|
||
| set(SPDLOG_FMT_EXTERNAL ON) | ||
| FetchContent_MakeAvailable(spdlog) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Copyright (c) Facebook, Inc. and its affiliates. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| include_guard(GLOBAL) | ||
|
|
||
| FetchContent_Declare( | ||
| ystdlib_cpp | ||
| GIT_REPOSITORY https://github.com/y-scope/ystdlib-cpp.git | ||
| GIT_TAG 0ae886c6a7ee706a3c6e1950262b63d72f71fe63) | ||
|
|
||
| FetchContent_Populate(ystdlib_cpp) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Once we upgrade clp to install ystdlib as a package, we should be able to use MakeAvailable instead. |
||
|
|
||
| set(CLP_YSTDLIB_SOURCE_DIRECTORY "${ystdlib_cpp_SOURCE_DIR}") | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -127,6 +127,7 @@ set(VELOX_GFLAGS_TYPE | |||||||||||||||
| ) | ||||||||||||||||
| option(VELOX_ENABLE_EXEC "Build exec." ON) | ||||||||||||||||
| option(VELOX_ENABLE_AGGREGATES "Build aggregates." ON) | ||||||||||||||||
| option(VELOX_ENABLE_CLP_CONNECTOR "Build CLP connector." ON) | ||||||||||||||||
| option(VELOX_ENABLE_HIVE_CONNECTOR "Build Hive connector." ON) | ||||||||||||||||
|
Comment on lines
130
to
131
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing compile-time define for the new flag Other feature toggles ( option(VELOX_ENABLE_CLP_CONNECTOR "Build CLP connector." ON)
+
+if(VELOX_ENABLE_CLP_CONNECTOR)
+ add_definitions(-DVELOX_ENABLE_CLP_CONNECTOR)
+endif()📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||
| option(VELOX_ENABLE_TPCH_CONNECTOR "Build TPC-H connector." ON) | ||||||||||||||||
| option(VELOX_ENABLE_PRESTO_FUNCTIONS "Build Presto SQL functions." ON) | ||||||||||||||||
|
|
@@ -174,6 +175,7 @@ if(${VELOX_BUILD_MINIMAL} OR ${VELOX_BUILD_MINIMAL_WITH_DWIO}) | |||||||||||||||
| set(VELOX_ENABLE_EXPRESSION ON) | ||||||||||||||||
| set(VELOX_ENABLE_EXEC OFF) | ||||||||||||||||
| set(VELOX_ENABLE_AGGREGATES OFF) | ||||||||||||||||
| set(VELOX_ENABLE_CLP_CONNECTOR OFF) | ||||||||||||||||
| set(VELOX_ENABLE_HIVE_CONNECTOR OFF) | ||||||||||||||||
| set(VELOX_ENABLE_TPCH_CONNECTOR OFF) | ||||||||||||||||
| set(VELOX_ENABLE_SPARK_FUNCTIONS OFF) | ||||||||||||||||
|
|
@@ -459,9 +461,11 @@ set(BOOST_INCLUDE_LIBRARIES | |||||||||||||||
| context | ||||||||||||||||
| date_time | ||||||||||||||||
| filesystem | ||||||||||||||||
| iostreams | ||||||||||||||||
| program_options | ||||||||||||||||
| regex | ||||||||||||||||
| system | ||||||||||||||||
| url | ||||||||||||||||
| thread) | ||||||||||||||||
|
|
||||||||||||||||
| velox_set_source(Boost) | ||||||||||||||||
|
|
@@ -518,6 +522,35 @@ endif() | |||||||||||||||
| velox_set_source(re2) | ||||||||||||||||
| velox_resolve_dependency(re2) | ||||||||||||||||
|
|
||||||||||||||||
| if(${VELOX_ENABLE_CLP_CONNECTOR}) | ||||||||||||||||
| velox_set_source(absl) | ||||||||||||||||
| velox_resolve_dependency(absl) | ||||||||||||||||
|
|
||||||||||||||||
| velox_set_source(antlr4-runtime) | ||||||||||||||||
| velox_resolve_dependency(antlr4-runtime) | ||||||||||||||||
|
|
||||||||||||||||
| velox_set_source(date) | ||||||||||||||||
| velox_resolve_dependency(date) | ||||||||||||||||
|
|
||||||||||||||||
| velox_set_source(msgpack-cxx) | ||||||||||||||||
| velox_resolve_dependency(msgpack-cxx) | ||||||||||||||||
|
|
||||||||||||||||
| velox_set_source(nlohmann_json) | ||||||||||||||||
| velox_resolve_dependency(nlohmann_json) | ||||||||||||||||
|
|
||||||||||||||||
| velox_set_source(simdjson) | ||||||||||||||||
| velox_resolve_dependency(simdjson) | ||||||||||||||||
|
|
||||||||||||||||
| velox_set_source(spdlog) | ||||||||||||||||
| velox_resolve_dependency(spdlog) | ||||||||||||||||
|
|
||||||||||||||||
| set(ystdlib_cpp_SOURCE BUNDLED) | ||||||||||||||||
| velox_resolve_dependency(ystdlib_cpp) | ||||||||||||||||
|
|
||||||||||||||||
| set(clp_SOURCE BUNDLED) | ||||||||||||||||
| velox_resolve_dependency(clp) | ||||||||||||||||
| endif() | ||||||||||||||||
|
|
||||||||||||||||
| if(${VELOX_BUILD_PYTHON_PACKAGE}) | ||||||||||||||||
| find_package( | ||||||||||||||||
| Python 3.9 | ||||||||||||||||
|
|
||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,31 @@ | ||||
| # Copyright (c) Facebook, Inc. and its affiliates. | ||||
| # | ||||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||||
| # you may not use this file except in compliance with the License. | ||||
| # You may obtain a copy of the License at | ||||
| # | ||||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||||
| # | ||||
| # Unless required by applicable law or agreed to in writing, software | ||||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||
| # See the License for the specific language governing permissions and | ||||
| # limitations under the License. | ||||
| #set(CLP_SRC_DIR ${clp_SOURCE_DIR}/components/core/src) | ||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Remove commented code. This commented line appears to be leftover code and should be removed to keep the build file clean. -#set(CLP_SRC_DIR ${clp_SOURCE_DIR}/components/core/src)📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||
| add_subdirectory(search_lib) | ||||
|
|
||||
| velox_add_library( | ||||
| velox_clp_connector | ||||
| OBJECT | ||||
| ClpConfig.cpp | ||||
| ClpConnector.cpp | ||||
| ClpDataSource.cpp | ||||
| ClpTableHandle.cpp) | ||||
|
|
||||
| velox_link_libraries(velox_clp_connector | ||||
| PRIVATE clp-s-search simdjson::simdjson velox_connector) | ||||
| target_compile_features(velox_clp_connector PRIVATE cxx_std_20) | ||||
|
|
||||
| if(${VELOX_BUILD_TESTING}) | ||||
| add_subdirectory(tests) | ||||
| endif() | ||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Environment variable likely ignored – use all-caps
BOOST_SOURCEinstead ofBoost_SOURCE.resolve_dependency.cmakeconverts package names to upper-case (e.g.,Boost→BOOST) and then looks forBOOST_SOURCE.With the current mixed-case key, Boost will silently fall back to the default (
BUNDLED), negating the intent of using the system-installed libraries and increasing build time.📝 Committable suggestion
🤖 Prompt for AI Agents