Fix swapped _aligned_malloc() arguments on Windows/MinGW#23
Open
colincoleman wants to merge 1 commit into
Open
Fix swapped _aligned_malloc() arguments on Windows/MinGW#23colincoleman wants to merge 1 commit into
colincoleman wants to merge 1 commit into
Conversation
tppm_init() allocates its aligned buffer with the MinGW _aligned_malloc()
in the HAVE__ALIGNED_MALLOC branch, but the call passes the arguments in
C11 aligned_alloc() order: _aligned_malloc(32, size). MSVCRT's signature is
_aligned_malloc(size_t size, size_t alignment), so the alignment argument
receives the buffer size (e.g. 17664), which is not a power of two.
_aligned_malloc() rejects it and returns NULL, so on Windows the true peak
meter fails to initialise ('Unable to init tppm system') and the feature is
unavailable.
Swap the arguments to match the _aligned_malloc() signature.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tppm_init() allocates its aligned buffer with the MinGW _aligned_malloc() in the HAVE__ALIGNED_MALLOC branch, but the call passes the arguments in C11 aligned_alloc() order: _aligned_malloc(32, size). MSVCRT's signature is _aligned_malloc(size_t size, size_t alignment), so the alignment argument receives the buffer size (e.g. 17664), which is not a power of two. _aligned_malloc() rejects it and returns NULL, so on Windows the true peak meter fails to initialise ('Unable to init tppm system') and the feature is unavailable.
Swap the arguments to match the _aligned_malloc() signature.
Fixes #22