Enable compilation using gcc#18
Open
mrehkopf wants to merge 6 commits into
Open
Conversation
- LCD address is an integer, not a pointer - correct data type format strings for sprintf - fp->buf / fs->win had previously been changed from an array into a pointer so the buffers can reside in 2nd SRAM; however sizeof then resolves to the size of the pointer itself, not the data; therefore `sizeof ...` is replaced with `FF_MAX_SS` - main function wasn't a prototype - compiler independent __WEAK macro is used in diskio.h instead of __weak which is IAR specific.
This is used for headered firmware ELF creation in the project where this Makefile is derived from, and has no bearing here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to compile this but do not have access to IAR, so I made a few changes to enable compilation using arm-none-eabi-gcc.
Some fixes had to be made to the code itself in order to achieve this (I notoriously compile using -Wall), none of which should break IAR compilation:
sizeof ...is replaced withFF_MAX_SS(this was a real bug actually, independent of compiler)Additionally,