Fix docker.client import.#1
Open
moigagoo wants to merge 3 commits into
Open
Conversation
added 3 commits
July 5, 2017 12:15
Apparently, docker package got updated and `Client` was replaced with `client`.
Owner
|
are you actually using this? i thought its not needed anymore. |
Author
|
@xsteadfastx Well, I use Docker a lot, and having autocompletions is very useful ¯_(ツ)_/¯ |
Owner
|
with what version did |
Author
|
According to https://docker-py.readthedocs.io/en/stable/change-log.html, 2.0.0. |
lieryan
added a commit
to lieryan/dotfiles
that referenced
this pull request
Jan 18, 2023
It's no longer needed, according to its own author xsteadfastx/xonsh-docker-tabcomplete#1 Testing also shows that docker completion works even when this isn't installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently, docker package got updated and
Clientwas replaced withclient.