Make batched vs list-model training test platform-robust - #450
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nikitakuklev
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_train_model_batch_compare_adamfails on macOS/ARM: tiny float64 reduction-order differences between the batched and per-model kernels (~1e-10) get amplified by Adam's adaptive normalization, exceeding the 1e-5 tolerance within a few steps.Rather than loosening the tolerance, this rewrites the test to check the invariant directly:
Measured on the previously failing platform: worst per-step loss difference 9e-16, max gradient difference 6e-17 (vs 2.7e-4 under Adam).