check last contextual variable value for nans and raise error - #448
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nikitakuklev
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling and validation of contextual variables in the Bayesian generator by ensuring that no NaN values are present in the latest row of training data for contextual variables. It also introduces a corresponding test to verify this behavior.
Validation improvements for contextual variables:
_validate_contextual_variables_no_nanto theBayesianGeneratorclass, which checks that the most recent row of training data does not contain NaN values in any contextual variable columns and raises aValueErrorif this condition is violated._validate_contextual_variables_no_nanbefore model training in thegeneratemethod.Testing enhancements:
test_contextual_variable_nan_in_last_row_raisesto ensure that aValueErroris raised if the latest row contains NaN in a contextual variable column during candidate generation.