Modernize nsga2 output_dir#445
Draft
ChristopherMayes wants to merge 1 commit into
Draft
Conversation
Collaborator
|
Pull in main to fix the testing issues here |
Collaborator
|
I can check out more later, but one point for thought: my preference is to keep the field as the raw value containing environment variables and home character and convert on usage (possibly through an That way the object reflects user input and can be serialized retaining their original data with environment variables. This is important, for instance, for the checkpointing feature of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR modernizes the
output_diroption ofNSGA2Generatorso that it accepts more flexible input while still serializing cleanly as a string.Changes
output_dirfield now accepts anyos.PathLikevalue, such as apathlib.Path, in addition to a plain string.$SCRATCHand the user home shortcut~are now expanded whenoutput_diris set, so paths like$SCRATCH/run1resolve to their intended locations._expand_output_dirfield validator performs this normalization by converting the input withos.fspathand expanding it withos.path.expandvarsandos.path.expanduser, while leavingNoneunchanged.Testing
pathlib.Pathinputs,$VARenvironment variables,~home expansion, andNoneare all handled correctly.NSGA2Generatortest suite inxopt/tests/generators/ga/test_nsga2.pycontinues to pass (32 tests).Acknowledgment
These changes were developed with the assistance of GitHub Copilot.