Skip to content

Fix the kind image loading issue #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tylergu merged 1 commit into from
Feb 22, 2026
Merged

Fix the kind image loading issue #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions acto/utils/image_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,33 @@
lock = FileLock(f"{archive_path}.lock")
with lock:
if os.path.exists(archive_path):
return archive_path

Check warning on line 35 in acto/utils/image_helper.py

View workflow job for this annotation

GitHub Actions / coverage-report

Missing coverage 

Missing coverage on line 35

for image in images:
# https://github.com/kubernetes-sigs/kind/issues/3795
subprocess.run(
[ImageHelper.image_tool, "pull", image],
[
ImageHelper.image_tool,
"pull",
"--platform",
"linux/amd64",
image,
],
stdout=subprocess.DEVNULL,
check=True,
)
os.makedirs(ImageHelper.image_archive_prefix, exist_ok=True)
# https://github.com/kubernetes-sigs/kind/issues/3795
subprocess.run(
[ImageHelper.image_tool, "image", "save", "-o", archive_path]
[
ImageHelper.image_tool,
"image",
"save",
"--platform",
"linux/amd64",
"-o",
archive_path,
]
+ list(images),
stdout=subprocess.DEVNULL,
check=True,
Expand Down
Loading