fix: IINA 1.4.4 plugin compatibility#256
Open
MidnightRoom wants to merge 1 commit into
Open
Conversation
IINA 1.4.4 no longer delivers 'iina.file-started' events to plugins, and URL-scheme mpv_script-opts are not passed through to mpv. - YouGetJSON.swift: put full iinaPlusArgs hex in video.mp4 URL query (previously only last 25 chars as suffix check) - AppDelegate.swift: add @mainactor to fix Sparkle init on Swift 6 Fixes xjbeta#255
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IINA 1.4.4 no longer delivers 'iina.file-started' events to plugins, and URL-scheme mpv_script-opts are not passed through to mpv.
This causes Bilibili videos to only play the 15-second empty.m4a placeholder with no video/audio (#255).
Changes
video.mp4?URL query (previously only last 25 chars as suffix check)@MainActorto fix Sparkle init on Swift 6 strict concurrencyRelated
Requires companion fix in iina-plugin-danmaku main.js: use
mpv.addHook('on_load')to intercept file loading.Fixes #255
Generated with assistance from glm