refactor(cli): deepen live scan lifecycles#125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RefreshCoordinatorBackfillCoordinatorScanStatusModelSearchIndexJobRunnerLiveScanStoreexternal interface while reducing its implementation from 1,382 to 928 linesWhy
LiveScanStoreowned four independent state machines through shared mutable fields. Lifecycle changes required coordinated edits across a 1,382-line implementation, and characterization tests reached through private fields to exercise behavior.The extracted modules are concrete internal modules, not speculative ports. They own their state and return transitions or snapshots to the store, which remains responsible for orchestration and external publication.
Validation
pnpm lintpnpm format:checkpnpm buildpnpm test(662 passed)pnpm test:coverage(72.89% statements, 75.50% lines)pnpm test:e2e(6 passed)pnpm bench:perf(149 sessions; dashboard 1,836 ms; detail 847 ms)Closes CS-44