refactor(core): centralize session indexing#124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Session ordering and lookup semantics were independently implemented in core orchestration, Web live updates, and Web indexes. That duplication made first-match route behavior, project identity keys, and SSE replacement semantics vulnerable to drift.
The new contract seam is pure and browser-safe, so both Node and Web adapters share behavior without sharing runtime-dependent instances.
Complexity note
The original
O(K log N)target is not achievable end to end while CLI and React callers require complete array snapshots: materializing a snapshot has anO(N)lower bound. This change avoids sorting already ordered snapshots and centralizes the work, but does not claim a benchmark speedup. At 25,000 sessions and 100 changes, the median comparison was 27.46 ms for the canonical path versus 26.80 ms for the repeated-sort model.A balanced incremental structure should only be introduced if callers can consume lazy ordered views; otherwise it adds implementation complexity without removing snapshot cost.
Validation
pnpm lintpnpm format:checkpnpm buildpnpm test(654 passed)pnpm test:e2e(6 passed)pnpm bench:session-indexCloses CS-43