feat(165): add code block#200
Open
ElizavetaAbramova wants to merge 6 commits into
Open
Conversation
ElizavetaAbramova
temporarily deployed
to
xi-development
GitHub Actions
Inactive
|
Contributor
|
А нам будто и не нужна вот такая модалка, она не сильно имеет смысл. Можно просто сразу создавать блок с кодом, пустой, без контента 
Вот тут я бы убрал белую рамку-подложку, она не сильно нужна 
|
| <NodeViewWrapper | ||
| className="group border-gray-10 bg-gray-0 relative my-4 rounded-xl border p-4 font-mono text-sm" | ||
| onMouseEnter={() => setHovered(true)} | ||
| onMouseLeave={() => setHovered(false)} |
Contributor
There was a problem hiding this comment.
Я наверное не замечал этот момент в других блоках. Но разве не стоит сделать это через стили, не храня состояние наведения для каждого блока?
Это можно как раз через group и group-hover сделать
| }, 50); | ||
| }; | ||
| }, [isOpen]); | ||
|
|
Contributor
There was a problem hiding this comment.
Хм, а что это и зачем, выглядит странно
| /* Стилизация блока кода */ | ||
| .tiptap pre { | ||
| background: #1e1e1e; | ||
| color: #d4d4d4; |
Contributor
There was a problem hiding this comment.
Я бы старался использовать наши токены через var
ElizavetaAbramova
temporarily deployed
to
xi-development
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Интеграция CodeBlockLowlight extension с кастомной оберткой для отображения текущего языка, смены языка, копирования в буфер
Адаптировано под темную и светлую тему