fix(pages.notes): add current users at note's header#199
Merged
Conversation
|
avea-maria
temporarily deployed
to
xi-development
GitHub Actions
Inactive
|
|
||
| useEffect(() => { | ||
| setUsers?.(users); | ||
| }, [setUsers, users]); |
Contributor
There was a problem hiding this comment.
Мне не очень нравится такое использование useEffect. Может быть вместо проброса setUsers через пропсы и использования users и setUsers сделать для них стор на Zustand?
| provider.awareness.off('change', handleGetUserIds); | ||
| } | ||
| }; | ||
| }, [provider.awareness, users]); |
Contributor
There was a problem hiding this comment.
Здесь будто users лишний, так как при изменении, в том числе через setUsers мы будем вновь с 0 пересоздавать весь useEffect
avea-maria
temporarily deployed
to
xi-development
GitHub Actions
Inactive
avea-maria
changed the title
avea-maria
temporarily deployed
to
xi-development
GitHub Actions
Inactive
unknownproperty
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #144
Для реализации нужно было отслеживать пользователей внутри едитора через WS и передвать информацию о пользователях в header. Но header не входил в context в котором находился едитор, а поднять context выше не представлялось правильным решением, т.к. едитор и заметки находятся в разных пакетах.
Решила сделать через общий useState и дриллинг пропсов.