This repository was archived by the owner on Apr 16, 2024. It is now read-only.
pkg.components.videoplayer#66
Open
AlexanderLukomsky wants to merge 6 commits into
Open
Conversation
AlexanderLukomsky
commented
Jul 5, 2023
AlexanderLukomsky
commented
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
|
||
| const [open, setOpen] = useState(false); | ||
|
|
||
| const handleOpen = () => { |
Contributor
There was a problem hiding this comment.
я бы отрефакторил обе функции в handleToggle
| <> | ||
| <Button onClick={handleOpen}>Open video</Button> | ||
|
|
||
| <Button onClick={() => setSelectedVideo((prev) => (prev === 0 ? 1 : 0))}> |
Contributor
There was a problem hiding this comment.
а вот эту бы функцию вынес
|
|
||
| return ( | ||
| <> | ||
| {!open && ( |
Contributor
There was a problem hiding this comment.
вместо !open && ... open && ...
можно open ? ... : ...
| import { formatTime } from './helpers'; | ||
| import 'pkg.config.muidts'; | ||
|
|
||
| type ControlsProps = { |
Contributor
There was a problem hiding this comment.
я бы добавил комментарии за что отвечает каждый проп
| })} | ||
| > | ||
| <Stack direction="row" alignItems="center" sx={controlsRowStyle}> | ||
| {!playing && ( |
Contributor
There was a problem hiding this comment.
тут тоже самое, что с open
| <VolumeControl volume={volume} onChange={onVolumeChange} /> | ||
|
|
||
| <IconButton sx={iconButtonStyle} onClick={onToggleScreenMode}> | ||
| {isFullScreen && <Minimize sx={iconStyle} />} |
| setPlayerState((prev) => ({ ...prev, playing: false })); | ||
| }; | ||
|
|
||
| const handleVolumeChange = (event: Event, value: number | number[]) => { |
Contributor
There was a problem hiding this comment.
а если всё же прилетит массив чисел? тут явно надо подумать, as не выход
| }; | ||
|
|
||
| const handlePlayerTimeChange = (event: Event, value: number | number[]) => { | ||
| reactPlayerRef.current?.seekTo((value as number) - 0.01); |
| return ( | ||
| <Box sx={{ position: 'relative', ml: 'auto' }}> | ||
| <IconButton onClick={handleIconClick} sx={iconButtonStyle}> | ||
| {volume > 0 && <SoundOn sx={iconStyle} />} |
Contributor
There was a problem hiding this comment.
тут тоже можно на ? :
| "eslint": "^7.32.0", | ||
| "eslint-config-custom": "*", | ||
| "pkg.config.typescript": "*", | ||
| "react": "^18.2.0", |
Contributor
There was a problem hiding this comment.
react тут лишний, он уже есть в dependencies
Contributor
Author
|
Исправил все замечания, так же отредактировал названия переменных. |
unknownproperty
approved these changes
Jul 7, 2023
unknownproperty
left a comment
unknownproperty
left a comment
Contributor
There was a problem hiding this comment.
Хорошо, спасибо, поставил аппрув, можно отнести отправить на тестирование
unknownproperty
added
the
ready to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.