This repository was archived by the owner on Apr 16, 2024. It is now read-only.
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
unknownproperty
left a comment
unknownproperty
left a comment
Contributor
There was a problem hiding this comment.
Так, комментарий по всему этому
Я сделал частичное ревью, продолжать дальше не имеет смысла
Что тебе стоит доработать:
- Вынести все иконки в pkg.icons, посмотреть как она там работают
- Все стили вынести в sx (кроме стилей, обозначенных как пропы)
- Попробовать использовать компоненты из pkg вместо дефолтных из MUI
Почему я говорю про стили? (второй пункт)
- Всё же хочется чтобы у нас был единый стиль кода, стили через sx используются в большей части кода
# Conflicts: # apps/xi.front/components/VideoConference/BottomBar/RightTool/RightTool.tsx # apps/xi.front/kit/UserProfile/ContentItems/SoundAndVideo/Btn.tsx # apps/xi.front/kit/UserProfile/ContentItems/SoundAndVideo/Styles/styles.ts # packages/pkg.inputs.select/Select.tsx
unknownproperty
approved these changes
Jun 20, 2023
unknownproperty
left a comment
unknownproperty
left a comment
Contributor
There was a problem hiding this comment.
Поставил аппрув, думаю, что можно смержить и отправить на пост тестирование, все баги вынести в отдельную задачу
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.