Skip to content
This repository was archived by the owner on Apr 16, 2024. It is now read-only.

9328294 Roles#45

Open
Bmwbyas wants to merge 15 commits into
stagingfrom
9328294
Open

9328294 Roles#45
Bmwbyas wants to merge 15 commits into
stagingfrom
9328294

Conversation

@Bmwbyas

@Bmwbyas Bmwbyas commented Apr 3, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

@vercel

vercel Bot commented Apr 3, 2023 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
xieffect ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2023 5:23am
xiworkshop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2023 5:23am

@unknownproperty

unknownproperty commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

Упали линтеры

Плюс мне не особо нравится такая много папочная архитектура, не совсем понятно почему одни папки с маленькой буквы, а другие с большой. Быть может вынесем всё на один уровень в папку Roles
image

unknownproperty
unknownproperty reviewed Apr 3, 2023
View reviewed changes
Comment thread apps/xi.front/kit/CommunityProfile/Content.tsx Outdated
import { Stack, useMediaQuery, Theme } from '@mui/material';
import Overview from './ContentItems/Overview';
import Roles from './ContentItems/Roles';
import Roles from './ContentItems/Roles/Roles';

@unknownproperty unknownproperty Apr 3, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Roles/Roles - так у нас не особо принято, лучше сделать экспорт компонента через index.tsx

@Bmwbyas Bmwbyas Apr 3, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

завтра поправлю

@Bmwbyas

Bmwbyas commented Apr 3, 2023

Copy link
Copy Markdown
Collaborator Author

xi.monorepo@0.0.0 format-check
prettier --check "**/*.{ts,tsx,md}"

Checking formatting...
[warn] jsxBracketSameLine is deprecated.
All matched files use Prettier code style!

Process finished with exit code 0
Вот это пишет мой компьютер.

Checking formatting...
[warn] jsxBracketSameLine is deprecated.
[warn] apps/xi.front/kit/CommunityProfile/ContentItems/Participants.tsx
[warn] Code style issues found in the above file. Forgot to run Prettier?
Error: Process completed with exit code 1.

Я в этом файле не лазил, который ему не нравится.

@Bmwbyas

Bmwbyas commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator Author

Я в этом файле Participants закоментил пару строчек кода которые не использовались

Base automatically changed from staging to main May 1, 2023 22:37
@niqzart niqzart changed the base branch from main to staging May 2, 2023 17:21
@unknownproperty

unknownproperty commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

Тут всё ещё конфликты

@Bmwbyas

Bmwbyas commented Jul 5, 2023

Copy link
Copy Markdown
Collaborator Author

попробую решить конфликты

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@unknownproperty unknownproperty unknownproperty left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bmwbyas @unknownproperty