This repository was archived by the owner on Apr 16, 2024. It is now read-only.
Conversation
mariik4
commented
Mar 27, 2023
mariik4
commented
Collaborator
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
unknownproperty
left a comment
unknownproperty
left a comment
Contributor
There was a problem hiding this comment.
Стоит всё же переименовать название и сделать слитно, да не очень красиво, но зато не бросается в глаза, так как snake_case мы вовсе не используем
| import { Grid, Stack, Typography, useTheme, useMediaQuery, Box } from '@mui/material'; | ||
| import { useStore } from 'store/connect'; | ||
| import { Arrow } from 'pkg.icons.arrow'; | ||
| import { DoubleArrow } from 'pkg.icons.double_arrow'; |
Contributor
There was a problem hiding this comment.
я бы лучше сделал слитно doublearrow
| alignItems="center" | ||
| sx={{ width: '108px', mr: '6px' }} | ||
| > | ||
| <Box onClick={getPrevMonth} sx={{ cursor: 'pointer' }}> |
Contributor
There was a problem hiding this comment.
Я бы тогда здесь передал component="button" или сделал бы лучше Button
| <Stack justifyContent="center" onClick={getNextWeek} sx={{ cursor: 'pointer' }}> | ||
| <Arrow sx={{ fontSize: '18px' }} /> | ||
| </Stack> | ||
| <Box onClick={getNextMonth} sx={{ cursor: 'pointer' }}> |
| <Stack spacing={0.25} key={`${task.id}`}> | ||
| {task.deadline && ( | ||
| <Badge | ||
| text="Дедлайн" |
Contributor
There was a problem hiding this comment.
Я переделал немного Badge, теперь text это children и находится он внутри тегов, то есть <Badge>Дедлайн</Badge>
| )} | ||
| {task.type === 'conference' && ( | ||
| <Badge | ||
| text="Конференция" |
| size="small" | ||
| icon={Camera} | ||
| iconProps={{ | ||
| sx: { width: '12px', height: '12px', fontSize: '12px' }, |
Contributor
There was a problem hiding this comment.
Если не ошибаюсь width, height по умолчанию такого размера у icon small
unknownproperty
added
the
ready to test
unknownproperty
approved these changes
May 3, 2023
mariik4
force-pushed
the
9647165
branch
2 times, most recently
from
5097978 to
cbbcdf5
Compare
added 2 commits
June 28, 2023 22:45
added 2 commits
July 10, 2023 13:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.