Skip to content

[4115] Фильтрация кабинетов#77

Closed
taaylor wants to merge 1 commit into
stagingfrom
feat/cabinet-filtering
Closed

[4115] Фильтрация кабинетов#77
taaylor wants to merge 1 commit into
stagingfrom
feat/cabinet-filtering

Conversation

@taaylor

@taaylor taaylor commented Oct 11, 2025

Copy link
Copy Markdown
Member

@taaylor taaylor self-assigned this Oct 11, 2025
@taaylor taaylor changed the title [DRAFT][4115] Фильтрация кабинетов Draft: [4115] Фильтрация кабинетов Oct 12, 2025
@taaylor taaylor force-pushed the feat/cabinet-filtering branch from eef6181 to f8de6ba Compare October 17, 2025 12:05
@taaylor taaylor changed the title Draft: [4115] Фильтрация кабинетов [4115] Фильтрация кабинетов Oct 17, 2025
@taaylor taaylor force-pushed the feat/cabinet-filtering branch 2 times, most recently from 30a322d to 04d4ca0 Compare October 17, 2025 12:43
@taaylor taaylor requested a review from ByrDen October 17, 2025 12:48

@ByrDen ByrDen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Основные проблемы: логика работы схем на поиск и нейминг)
А так начало хорошее)

Comment thread app/classrooms/models/classrooms_db.py Outdated
Comment thread app/classrooms/services/classrooms_svc.py Outdated
Comment thread tests/classrooms/functional/test_classrooms_list_rst.py Outdated
Comment thread app/classrooms/models/classrooms_db.py Outdated
Comment thread tests/classrooms/functional/test_classrooms_list_rst.py Outdated
Comment thread tests/classrooms/functional/test_classrooms_list_rst.py Outdated
Comment thread tests/classrooms/functional/test_classrooms_list_rst.py Outdated
@taaylor taaylor force-pushed the feat/cabinet-filtering branch 2 times, most recently from b6dcf8e to aee478b Compare October 25, 2025 10:08

@ByrDen ByrDen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

любимый твой нейминг :)

Comment thread app/classrooms/models/classrooms_db.py Outdated
Comment thread app/classrooms/models/classrooms_db.py Outdated
Comment thread tests/classrooms/functional/test_classrooms_list_rst.py Outdated
Comment thread tests/classrooms/functional/test_classrooms_list_rst.py Outdated
@taaylor taaylor force-pushed the feat/cabinet-filtering branch 2 times, most recently from 3950b67 to 62bbd42 Compare November 1, 2025 12:53

@ByrDen ByrDen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

один момент остался из старых

@taaylor taaylor force-pushed the feat/cabinet-filtering branch from 62bbd42 to 0c4dfe5 Compare November 2, 2025 16:03

@ByrDen ByrDen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

На этом мои полномочия всё :)

@niqzart niqzart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Много isses, надо как-то их ловить до меня. Присмотрись к реализации в materials

Comment thread app/classrooms/models/classrooms_db.py Outdated
Comment thread app/classrooms/models/classrooms_db.py Outdated
Comment thread app/classrooms/models/classrooms_db.py Outdated
Comment thread app/classrooms/services/classrooms_svc.py Outdated
Comment thread app/classrooms/routes/classrooms_tutor_rst.py Outdated
Comment thread app/classrooms/routes/classrooms_tutor_rst.py Outdated
Comment thread app/classrooms/models/classrooms_db.py Outdated
Comment thread app/classrooms/models/classrooms_db.py Outdated
Comment thread tests/classrooms/functional/test_classrooms_list_rst.py Outdated
@niqzart niqzart added ci:covered If coverage checks should be run on the PR ci:migrated If migration checks should be run on the PR labels Nov 3, 2025
@taaylor taaylor force-pushed the feat/cabinet-filtering branch from 0c4dfe5 to 8f37be3 Compare November 12, 2025 21:03

@niqzart niqzart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Очень много repeat-ов. Надо внимательнее

Comment thread app/classrooms/services/classrooms_svc.py Outdated
Comment thread app/classrooms/models/classrooms_db.py Outdated
Comment thread app/classrooms/services/classrooms_svc.py Outdated
Comment thread tests/classrooms/functional/test_classrooms_list_rst.py Outdated
Comment thread tests/classrooms/functional/test_classrooms_list_rst.py Outdated
@taaylor taaylor force-pushed the feat/cabinet-filtering branch 2 times, most recently from 9d36d92 to 599895b Compare November 15, 2025 18:53

@niqzart niqzart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Прогресс есть, но добивать ещё есть что

Comment thread app/classrooms/routes/classrooms_student_rst.py
Comment thread tests/classrooms/functional/test_classrooms_list_rst.py Outdated
Comment thread tests/classrooms/functional/test_classrooms_list_rst.py Outdated
Comment thread tests/classrooms/functional/test_classrooms_list_rst.py Outdated
Comment thread tests/classrooms/functional/test_classrooms_list_rst.py Outdated
Comment thread tests/classrooms/functional/test_classrooms_list_rst.py Outdated
Comment thread tests/classrooms/functional/test_classrooms_list_rst.py Outdated
Comment thread tests/classrooms/functional/test_classrooms_list_rst.py
Comment thread tests/classrooms/functional/test_classrooms_list_rst.py Outdated
Comment thread tests/classrooms/functional/test_classrooms_list_rst.py Outdated
@taaylor taaylor force-pushed the feat/cabinet-filtering branch from 599895b to 8fec825 Compare December 14, 2025 13:51
@taaylor taaylor closed this Dec 23, 2025
@taaylor taaylor reopened this Dec 23, 2025
@niqzart

niqzart commented Jan 10, 2026

Copy link
Copy Markdown
Member

Moved to #101

@niqzart niqzart closed this Jan 10, 2026
@niqzart niqzart deleted the feat/cabinet-filtering branch February 1, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:covered If coverage checks should be run on the PR ci:migrated If migration checks should be run on the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants