feat(rust/hyper): Add hyper server demo by hackerchai · Pull Request #15 · xgo-dev/llgoexamples

hackerchai · 2024-08-05T10:06:55Z

This PR need LLGo #700 and LLGo #706 to be merged first.

refactor(rust/hyper): Update server demo due to llgo changes fix(rust/hyper): Fix some errs Signed-off-by: hackerchai <i@hackerchai.com> fix(rust/hyper/demo): Fix errors in server demo Signed-off-by: hackerchai <i@hackerchai.com>

Signed-off-by: hackerchai <i@hackerchai.com> fix(rust/hyper/demo): Fix hyper response task error Signed-off-by: hackerchai <i@hackerchai.com>

Signed-off-by: hackerchai <i@hackerchai.com>

Signed-off-by: hackerchai <i@hackerchai.com> # Conflicts: # go.mod # go.sum

hackerchai · 2024-08-13T08:55:50Z

@xushiwei @aofei @visualfc ready for review.

…rite replacing poll logic Signed-off-by: hackerchai <i@hackerchai.com>

Signed-off-by: hackerchai <i@hackerchai.com>

qiniu-x · 2024-09-02T10:20:40Z

+
+func freeConnData(userdata c.Pointer) {
+	conn := (*ConnData)(userdata)
+	if conn != nil && !conn.IsClosing.Swap(true){


[gofmt] Is your code not properly formatted? Here are some suggestions below

Suggested change

if conn != nil && !conn.IsClosing.Swap(true){

if conn != nil && !conn.IsClosing.Swap(true) {

Details

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-09-02T10:20:41Z

+            (*libuv.Handle)(unsafe.Pointer(&conn.PollHandle)).Close(nil)
+        }
+
+        if (*libuv.Handle)(unsafe.Pointer(&conn.Stream)).IsClosing() == 0 {
+            (*libuv.Handle)(unsafe.Pointer(&conn.Stream)).Close(nil)
+        }


[gofmt] Is your code not properly formatted? Here are some suggestions below

Suggested change

(*libuv.Handle)(unsafe.Pointer(&conn.PollHandle)).Close(nil)

}

if (*libuv.Handle)(unsafe.Pointer(&conn.Stream)).IsClosing() == 0 {

(*libuv.Handle)(unsafe.Pointer(&conn.Stream)).Close(nil)

}

(*libuv.Handle)(unsafe.Pointer(&conn.PollHandle)).Close(nil)

}

if (*libuv.Handle)(unsafe.Pointer(&conn.Stream)).IsClosing() == 0 {

(*libuv.Handle)(unsafe.Pointer(&conn.Stream)).Close(nil)

}

Details

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-09-02T10:20:42Z

+    if userdata == nil {
+        fmt.Fprintf(os.Stderr, "Failed to allocate service_userdata\n")
+    }
+    return userdata


[gofmt] Is your code not properly formatted? Here are some suggestions below

Suggested change

if userdata == nil {

fmt.Fprintf(os.Stderr, "Failed to allocate service_userdata\n")

}

return userdata

if userdata == nil {

fmt.Fprintf(os.Stderr, "Failed to allocate service_userdata\n")

}

return userdata

Details

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-09-02T10:20:43Z

+			(*libuv.Handle)(unsafe.Pointer(&conn.Stream)).Close(nil)
+			return
+		}
+


[gofmt] Is your code not properly formatted? Here are some suggestions below

Suggested change

(*libuv.Handle)(unsafe.Pointer(&conn.PollHandle)).Data = unsafe.Pointer(conn)

Details

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-09-02T10:20:44Z

+		}
+
+		(*libuv.Handle)(unsafe.Pointer(&conn.PollHandle)).Data = unsafe.Pointer(conn)
+


[gofmt] Is your code not properly formatted? Here are some suggestions below

Suggested change

if !updateConnDataRegistrations(conn, true) {

Details

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-09-02T10:20:45Z

+    for task != nil {
+        taskType := task.Type()
+        if taskType == hyper.TaskError {
+            fmt.Println("hyper task failed with error!")
+
+            err := (*hyper.Error)(task.Value())
+            fmt.Printf("error code: %d\n", err.Code())
+
+            var errbuf [256]byte
+            errlen := err.Print(&errbuf[0], unsafe.Sizeof(errbuf))
+            fmt.Printf("details: %s\n", errbuf[:errlen])
+
+            err.Free()
+            task.Free()
+        } else if taskType == hyper.TaskEmpty {
+            fmt.Println("internal hyper task complete")
+            task.Free()
+        } else if taskType == hyper.TaskServerconn {
+            fmt.Println("server connection task complete")
+            task.Free()
+        }


[gofmt] Is your code not properly formatted? Here are some suggestions below

Suggested change

for task != nil {

taskType := task.Type()

if taskType == hyper.TaskError {

fmt.Println("hyper task failed with error!")

err := (*hyper.Error)(task.Value())

fmt.Printf("error code: %d\n", err.Code())

var errbuf [256]byte

errlen := err.Print(&errbuf[0], unsafe.Sizeof(errbuf))

fmt.Printf("details: %s\n", errbuf[:errlen])

err.Free()

task.Free()

} else if taskType == hyper.TaskEmpty {

fmt.Println("internal hyper task complete")

task.Free()

} else if taskType == hyper.TaskServerconn {

fmt.Println("server connection task complete")

task.Free()

}

for task != nil {

taskType := task.Type()

if taskType == hyper.TaskError {

fmt.Println("hyper task failed with error!")

err := (*hyper.Error)(task.Value())

fmt.Printf("error code: %d\n", err.Code())

var errbuf [256]byte

errlen := err.Print(&errbuf[0], unsafe.Sizeof(errbuf))

fmt.Printf("details: %s\n", errbuf[:errlen])

err.Free()

task.Free()

} else if taskType == hyper.TaskEmpty {

fmt.Println("internal hyper task complete")

task.Free()

} else if taskType == hyper.TaskServerconn {

fmt.Println("server connection task complete")

task.Free()

}

Details

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-09-02T10:20:46Z

+    }
+
+    if shouldExit.Load() {
+        fmt.Println("Shutdown initiated, cleaning up...")
+        handle.Stop()
+    }


[gofmt] Is your code not properly formatted? Here are some suggestions below

Suggested change

}

if shouldExit.Load() {

fmt.Println("Shutdown initiated, cleaning up...")

handle.Stop()

}

}

if shouldExit.Load() {

fmt.Println("Shutdown initiated, cleaning up...")

handle.Stop()

}

Details

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-09-02T10:20:47Z

+	"github.com/goplus/llgo/c/net"
+	cos "github.com/goplus/llgo/c/os"
+	"github.com/goplus/llgo/c/syscall"
+


[gofmt] Is your code not properly formatted? Here are some suggestions below

Suggested change

"github.com/goplus/llgoexamples/rust/hyper"

Details

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-09-02T10:20:48Z

+	loop                        *libuv.Loop
+	server                      libuv.Tcp
+	checkHandle                 libuv.Check
+	sigintHandle, sigtermHandle libuv.Signal             


[gofmt] Is your code not properly formatted? Here are some suggestions below

Suggested change

sigintHandle, sigtermHandle libuv.Signal

sigintHandle, sigtermHandle libuv.Signal

Details

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-09-02T10:20:49Z

+	Stream       libuv.Tcp
+	PollHandle   libuv.Poll
+	EventMask    c.Uint
+	ReadWaker    *hyper.Waker
+	WriteWaker   *hyper.Waker
+    IsClosing   atomic.Bool
+    ClosedHandles int32


[gofmt] Is your code not properly formatted? Here are some suggestions below

Suggested change

Stream libuv.Tcp

PollHandle libuv.Poll

EventMask c.Uint

ReadWaker *hyper.Waker

WriteWaker *hyper.Waker

IsClosing atomic.Bool

ClosedHandles int32

Stream libuv.Tcp

PollHandle libuv.Poll

EventMask c.Uint

ReadWaker *hyper.Waker

WriteWaker *hyper.Waker

IsClosing atomic.Bool

ClosedHandles int32

Details

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-09-02T10:20:50Z

+	serviceData := (*ServiceUserdata)(userdata)
+
+	fmt.Printf("Handling request on connection from %s:%s\n",
+	c.GoString((*c.Char)(&serviceData.Host[0])), c.GoString((*c.Char)(&serviceData.Port[0])))


[gofmt] Is your code not properly formatted? Here are some suggestions below

Suggested change

c.GoString((*c.Char)(&serviceData.Host[0])), c.GoString((*c.Char)(&serviceData.Port[0])))

c.GoString((*c.Char)(&serviceData.Host[0])), c.GoString((*c.Char)(&serviceData.Port[0])))

Details

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-09-02T10:20:51Z

+    if err != nil {
+        fmt.Fprintf(os.Stderr, "Failed to create conn_data\n")
+        return
+    }


[gofmt] Is your code not properly formatted? Here are some suggestions below

Suggested change

if err != nil {

fmt.Fprintf(os.Stderr, "Failed to create conn_data\n")

return

}

if err != nil {

fmt.Fprintf(os.Stderr, "Failed to create conn_data\n")

return

}

Details

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-09-02T10:20:52Z

+    if exec != nil {
+        exec.Free()
+    }
+    if http1Opts != nil {
+        http1Opts.Free()
+    }
+    if http2Opts != nil {
+        http2Opts.Free()
+    }


[gofmt] Is your code not properly formatted? Here are some suggestions below

Suggested change

if exec != nil {

exec.Free()

}

if http1Opts != nil {

http1Opts.Free()

}

if http2Opts != nil {

http2Opts.Free()

}

if exec != nil {

exec.Free()

}

if http1Opts != nil {

http1Opts.Free()

}

if http2Opts != nil {

http2Opts.Free()

}

Details

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-09-02T10:20:53Z

+	"fmt"
+	"os"
+	"unsafe"
+	"sync/atomic"


[gofmt] Is your code not properly formatted? Here are some suggestions below

Suggested change

"sync/atomic"

"unsafe"

Details

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

hackerchai marked this pull request as ready for review August 8, 2024 07:38

hackerchai marked this pull request as draft August 8, 2024 07:38

hackerchai force-pushed the feature/hyper-server-demo branch from 86856f1 to 521ca79 Compare August 13, 2024 08:40

hackerchai added 5 commits August 13, 2024 16:43

refactor(rust/hyper): Add hyper server funcs and structs

cd929b4

feat(rust/hyper/demo): Add hyper server demo prototype

1307a6f

refactor(rust/hyper): Update server demo due to llgo changes fix(rust/hyper): Fix some errs Signed-off-by: hackerchai <i@hackerchai.com> fix(rust/hyper/demo): Fix errors in server demo Signed-off-by: hackerchai <i@hackerchai.com>

fix(rust/hyper/demo): Fix struct mem bug & hyper response task error

ff82646

Signed-off-by: hackerchai <i@hackerchai.com> fix(rust/hyper/demo): Fix hyper response task error Signed-off-by: hackerchai <i@hackerchai.com>

refactor(rust/hyper/demo): Replace c Printf with go fmt.Printf

3bbb19e

Signed-off-by: hackerchai <i@hackerchai.com>

chore(deps): Update llgo

ef31104

Signed-off-by: hackerchai <i@hackerchai.com> # Conflicts: # go.mod # go.sum

hackerchai force-pushed the feature/hyper-server-demo branch from 521ca79 to ef31104 Compare August 13, 2024 08:44

hackerchai marked this pull request as ready for review August 13, 2024 08:45

hackerchai added 2 commits August 27, 2024 17:51

refactor(rust/hyper/demo): Refactor server libuv using uv_read & uv_w…

ef72e72

…rite replacing poll logic Signed-off-by: hackerchai <i@hackerchai.com>

feat(rust/hyper/demo): Add server_legacy poll implement

3197685

Signed-off-by: hackerchai <i@hackerchai.com>

qiniu-x Bot reviewed Sep 2, 2024

View reviewed changes

	if conn != nil && !conn.IsClosing.Swap(true){
	if conn != nil && !conn.IsClosing.Swap(true) {



	(*libuv.Handle)(unsafe.Pointer(&conn.PollHandle)).Data = unsafe.Pointer(conn)

	sigintHandle, sigtermHandle libuv.Signal
	sigintHandle, sigtermHandle libuv.Signal

	c.GoString((c.Char)(&serviceData.Host[0])), c.GoString((c.Char)(&serviceData.Port[0])))
	c.GoString((c.Char)(&serviceData.Host[0])), c.GoString((c.Char)(&serviceData.Port[0])))

Uh oh!

Conversation

hackerchai commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hackerchai commented Aug 13, 2024

Uh oh!

qiniu-x Bot Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

qiniu-x Bot Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

qiniu-x Bot Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

qiniu-x Bot Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

qiniu-x Bot Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

qiniu-x Bot Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

qiniu-x Bot Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

qiniu-x Bot Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

qiniu-x Bot Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

qiniu-x Bot Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

qiniu-x Bot Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

qiniu-x Bot Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

qiniu-x Bot Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

qiniu-x Bot Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

hackerchai commented Aug 5, 2024 •

edited

Loading