Skip to content

runtime/internal/lib/reflect: fix toFFIArg interface itab #2021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xushiwei merged 1 commit into from
Jul 4, 2026
+36 −6
Merged

runtime/internal/lib/reflect: fix toFFIArg interface itab #2021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/test_demo.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ ignore_esp32=(
"./_demo/go/reflectempty" # panic: internal/bytealg selected .s files require plan9asm translation
"./_demo/go/reflectfunc" # panic: internal/bytealg selected .s files require plan9asm translation
"./_demo/go/reflectfnconv" # panic: internal/bytealg selected .s files require plan9asm translation
"./_demo/go/reflectifacecall" # panic: internal/bytealg selected .s files require plan9asm translation
"./_demo/go/reflectindirect" # panic: internal/bytealg selected .s files require plan9asm translation
"./_demo/go/reflectmake" # panic: internal/bytealg selected .s files require plan9asm translation
"./_demo/go/reflectmethod" # panic: internal/bytealg selected .s files require plan9asm translation
Expand Down Expand Up @@ -185,6 +186,7 @@ ignore_esp32c3_basic=(
"./_demo/go/reflectconv" # panic: internal/bytealg selected .s files require plan9asm translation
"./_demo/go/reflectfunc" # panic: internal/bytealg selected .s files require plan9asm translation
"./_demo/go/reflectfnconv" # panic: internal/bytealg selected .s files require plan9asm translation
"./_demo/go/reflectifacecall" # panic: internal/bytealg selected .s files require plan9asm translation
"./_demo/go/reflectindirect" # panic: internal/bytealg selected .s files require plan9asm translation
"./_demo/go/reflectcopy" # panic: internal/bytealg selected .s files require plan9asm translation
"./_demo/go/reflectempty" # panic: internal/bytealg selected .s files require plan9asm translation
Expand Down
20 changes: 20 additions & 0 deletions _demo/go/reflectifacecall/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
package main

import (
"reflect"
)

func main() {
fn := reflect.ValueOf(reflect.New)
typ := reflect.TypeOf(0)
v := reflect.ValueOf(typ)
r := fn.Call([]reflect.Value{v})
e := r[0].Interface().(reflect.Value).Elem()
if e.Kind() != reflect.Int {
panic("error kind")
}
e.SetInt(100)
if e.Interface().(int) != 100 {
panic("error value")
}
}
20 changes: 14 additions & 6 deletions runtime/internal/lib/reflect/value.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,11 +243,10 @@ type emptyInterface struct {
type nonEmptyInterface struct {
// see ../runtime/iface.go:/Itab
itab *struct {
ityp *abi.Type // static interface type
typ *abi.Type // dynamic concrete type
hash uint32 // copy of typ.hash
_ [4]byte
fun [100000]unsafe.Pointer // method table
inter *abi.InterfaceType
typ *abi.Type
hash uint32 // copy of _type.hash. Used for type switches.
fun [1]uintptr // variable sized. fun[0]==0 means _type does not implement inter.
}
word unsafe.Pointer
}
Expand Down Expand Up @@ -2313,7 +2312,16 @@ func toFFIArg(v Value, typ *abi.Type) unsafe.Pointer {
return unsafe.Pointer(&v.ptr)
case abi.Interface:
i := v.Interface()
return unsafe.Pointer(&i)
iface := typ.InterfaceType()
if len(iface.Methods) == 0 {
return unsafe.Pointer(&i)
}
itab := runtime.NewItab(iface, v.typ())
data := struct {
itab *runtime.Itab
data unsafe.Pointer
}{itab, (*emptyInterface)(unsafe.Pointer(&i)).word}
return unsafe.Pointer(&data)
case abi.Map:
return toFFIWordArg(v)
case abi.Pointer:
Expand Down
Loading