runtime: speed up funcinfo hot paths#2010
Closed
cpunion wants to merge 23 commits into
Closed
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2009.
Performance follow-up for compact runtime funcinfo. This PR narrows hot-path overhead after entry-PC materialization and adds a reusable comparison benchmark.
Changes
runtime.FuncForPCas a caller-frame tracking API. Funcinfo metadata is still emitted, but FuncForPC-only packages no longer get caller-frame / pcline instrumentation.CallersFramesline lookups avoid a full-table binary search.FuncForPCcache 4-way associative to avoid direct-mapped cache thrashing across many function-value PCs.benchmark/runtime_funcinfofor repeatable cross-branch runtime funcinfo performance and size comparisons.Validation
go build -o /tmp/llgo-2010-fixed-final ./cmd/llgogo test ./benchmark/runtime_funcinfogo test ./cl -run 'FuncForPC|CallerFrame|RuntimeCaller|Pcline|FuncInfo'go test ./test/go -run 'TestRuntime(LineInfoAndStack|FuncInfoConcurrentFirstUse|StatementLineInfo)' -count=1-iters=200000 -packages=12 -methods=12Cells are
best/trimmed avg. Runtime metrics usens/us.multipkg.*Manyis one batch over 144 target functions.macOS Performance
macOS LTO Spot Check
LTO Scaling Sanity
macOS Size