runtime: avoid stale unbuffered receive waits#2003
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cpunion
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a deadlock in llgo's unbuffered channel runtime where a receive that had already completed could keep waiting if another receive on the same channel overwrote the shared receive state before the first waiter woke up.
Root Cause
The runtime used channel-level
getpstate to determine whether an unbuffered receive rendezvous had completed. In a sequence likeselect { case <-ch: ... default: ... }followed immediately by another<-chon the same channel, the later receive could setgetpback tochanHasRecv, causing the earlier completed receive to wait forever.Changes
runtime/internal/runtime.Chan.ChanSendorChanTrySendcompletes an unbuffered rendezvous.ChanRecvand select receive completion checks use the captured sequence as well asgetp.test/select_test.gothat runs with bothgo testandllgo test.Validation
go test ./test -run '^TestSelectRecvCompletionNotOverwrittenByNextRecv$' -count=1timeout 30s ./llgo test ./test -run '^TestSelectRecvCompletionNotOverwrittenByNextRecv$' -count=1TestPublishV3Retry; it now passes instead of hanging.