ssa: panic with runtime type assertion errors

[cpunion]

Summary

• lower failed non-comma-ok type assertions through a runtime TypeAssertionError helper instead of panic(string)
• add stable test/go coverage for recovered runtime.Error values on interface-to-interface and interface-to-concrete assertions
• remove fixed fixedbugs/issue16130.go GOROOT xfails; leave issue32187 comparison xfails untouched

Testing

• go test ./test/go -run 'TestInterfaceAssert|TestNilInterfaceSameTypeAssertPanics|TestInterfaceCompareUncomparable' -count=1\n- go test ./test/go -count=1\n- (cd runtime && go test ./internal/runtime -run 'TestDoesNotExist' -count=1)\n- LLGO_ROOT="$PWD" go run -tags=dev ./cmd/llgo test -run 'TestInterfaceAssert|TestNilInterfaceSameTypeAssertPanics|TestInterfaceCompareUncomparable' ./test/go\n- go test ./ssa -count=1\n- go test ./test/goroot -run TestGoRootRunCases/fixedbugs/issue16130.go -count=1 -args -goroot "$(go env GOROOT)" -dirs fixedbugs -case '^fixedbugs/issue16130\.go$' -xfail /tmp/llgo-no-xfail.yaml\n- go test ./test/goroot -run TestGoRootRunCases/fixedbugs/issue16130.go -count=1 -args -goroot "$(go env GOROOT)" -dirs fixedbugs -case '^fixedbugs/issue16130\.go$'\n\n## Notes\nGOROOT CI is slow/disabled, so this PR does not depend on automatic full GOROOT runs. The targeted local GOROOT check used the current machine GOROOT (go env GOROOT = /opt/homebrew/Cellar/go@1.24/1.24.11/libexec). Normal PR CI should still run from the fork branch.\n\nA non-targeted local LLGO_ROOT="$PWD" go run -tags=dev ./cmd/llgo test ./test/go run reached test execution but failed on darwin temp-dir cleanup with operation not permitted in existing temp-dir cleanup paths; the focused interface assertion llgo test above passed.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[cpunion]

Update for latest interface/nointerface coverage (head c9e354c):

Scope:

• interface/nointerface only; no chan/nil/print/recover/GC/liveness/finalizer/goroutine changes.
• //go:nointerface methods are recorded during AST directive scan and omitted from runtime ABI method tables, while direct method calls/method expressions remain available.

GOROOT xfails removed after targeted local verification:

• typeparam/mdempsky/15.go (//go:nointerface, generics, promoted methods)
• fixedbugs/issue47928.go (promoted //go:nointerface method)
• typeparam/mdempsky/16.go (interface type assertion panic text; already fixed by this PR's earlier assertion-error work)

Coverage:

• Added test/go/nointerface_test.go plus llgo/non-llgo expectation files. Host Go's default toolchain does not filter nointerface without the fieldtrack experiment, while llgo should filter under the llgo tag.

Local tests:

• go test ./test/go -count=1
• go test ./ssa -count=1
• go test ./cl -count=1
• go test ./test/goroot -run TestGoRootRunCases -count=1 -args -goroot "$(go env GOROOT)" -dirs typeparam/mdempsky,fixedbugs -case '^(typeparam/mdempsky/(15|16)|fixedbugs/issue47928)\.go$' -directive-mode runlike -run-timeout 120s

Not covered here:

• Remaining non-nointerface xfails such as typeparam/nested.go and unrelated chan/nil/print/recover/GC cases are intentionally left for their owning domains.

[cpunion]

Update for commit 64ae33c:\n\n- Added reflect/interface type identity coverage for reflect.Type.Method and MethodByName: Method.Func.Interface() now asserts to and calls func(*T) / func(T) using the canonical LLGo closure-backed function type.\n- Fixed reflect.Type interface invokes to request method ABI type initialization, included closure ABI symbols for reflect method FuncOf lookup, and boxed Type.Method Func values as LLGo closure values while preserving public reflect Type identity.\n- recover.go classification: without #1882 it still stops at the existing recover-frame failure (spurious recover). With #1882's recover-frame fix layered locally, the previous func(*T1) vs func(*T1) type identity failure is gone; the next observed failure is missing recover 10, which is recover semantics and intentionally not covered here. No recover.go xfail removed.\n- Local tests: go test ./test/go -count=1; go run ./cmd/llgo test -run TestReflectTypeMethodFuncInterfaceTypeIdentity -count=1 ./test/go; go test ./ssa -count=1; go test ./cl -count=1; go test ./internal/build -count=1; focused goroot recover.go with existing xfail passed.

[cpunion]

Coverage update for fixedbugs/issue26094.go (commit 5733be6aa6aa6f2bb3782a00ae49e7bc8c960989):

• Classified as the same local type identity / interface assertion root as this draft PR: different scopes can produce the same printed type name, but interface assertion must compare scoped type identity and panic with different scopes.
• Added stable test/go coverage in TestInterfaceAssertRejectsSameNameTypesFromDifferentScopes for local-vs-local and local-vs-package same-name type assertions.
• Removed only the now-covered fixedbugs/issue26094.go goroot xfail entries for darwin/arm64 and linux/amd64. No nil/chan/print/recover/GC/finalizer/goroutine cases were changed.

Focused local validation:

• go test ./test/go -run 'TestInterfaceAssert(RejectsSameNameTypesFromDifferentScopes|To.*Panics)' -count=1\n- go test ./test/goroot -run TestGoRootRunCases/fixedbugs/issue26094.go -count=1 -args -goroot /Users/lijie/sdk/go1.26.0 -dirs fixedbugs -case '^fixedbugs/issue26094\\.go$' -progress 30s\n- go test ./test/go -count=1\n- go test ./ssa/... ./cl/... ./runtime/... -count=1 reported ssa and cl OK; the command itself returned FAIL because ./runtime/... is a separate module path from the repo root.\n- (cd runtime && go test ./... -count=1) passed.

[cpunion]

Merged latest xgo-dev/main and resolved the remaining #1892 conflicts.

Conflict/coverage updates:

• Kept the mainline reflect Method.Func closure boxing and combined it with this PR's interface assertion closure matching semantics.
• Fixed the malformed adjacent xfail entries for typeparam/issue51521.go and typeparam/orderedmap.go while keeping ssa: panic with runtime type assertion errors #1892-owned xfails removed.
• Added package-level coverage for //go:nointerface parsing/filtering and reflect-method closure ABI symbol filtering: cl/import_coverage_test.go, ssa/nointerface_test.go, internal/build/main_module_test.go.

Local verification:

• go test -timeout 20m ./test/go -run 'Test(InterfaceAssert|NilInterfaceSameTypeAssertPanics|InterfaceCompareUncomparable|NoInterface|ReflectTypeMethodFuncInterfaceTypeIdentity)' -count=1\n- go test -timeout 20m ./ssa ./cl -run 'Test.*(Interface|NoInterface|FuncType|Method|TypeAssert|Import|ABI|Closure)|TestDoesNotExist' -count=1\n- cd runtime && go test -timeout 20m ./internal/runtime ./internal/lib/reflect -count=1\n- go test -timeout 30m ./test/goroot -run TestGoRootRunCases -count=1 -args -goroot /Users/lijie/sdk/go1.26.0 -dirs fixedbugs,typeparam/mdempsky -case '^(fixedbugs/(issue16130|issue26094|issue47928)|typeparam/mdempsky/(15|16))\.go$' -directive-mode runlike -run-timeout 120s\n- go test -timeout 20m ./cl -coverprofile=/tmp/llgo-1892-cl.cover -count=1 (93.8%)\n- go test -timeout 20m ./ssa -coverprofile=/tmp/llgo-1892-ssa.cover -count=1 (87.9%)\n- go test -timeout 20m ./internal/build -coverprofile=/tmp/llgo-1892-build.cover -count=1 (67.4%)\n- LLGO_ROOT="$PWD" go run -tags=dev ./cmd/llgo test -run 'Test(InterfaceAssert|NilInterfaceSameTypeAssertPanics|NoInterface|ReflectTypeMethodFuncInterfaceTypeIdentity)' -count=1 ./test/go\n- git diff --check && git diff --cached --check

[cpunion]

Rebased onto #2016 (codex/pclntab-linkphase-p1, which includes #2012) per the review-order plan: #2012 → #2016 → this line of semantics fixes. Conflicts resolved were additive (context fields, the noinline condition set, and runtime.Panic now calls SavePanicCallerFrames() before the panic-node bookkeeping). Note the PR base is still main, so the diff shows #2012/#2016 commits until those merge.