Skip to content

feat(build): add kodo artifact store#134

Merged
luoliwoshang merged 2 commits into
xgo-dev:mainfrom
MeteorsLiu:feat/kodo-cache-metadata-artifact
Jul 3, 2026
Merged

feat(build): add kodo artifact store#134
luoliwoshang merged 2 commits into
xgo-dev:mainfrom
MeteorsLiu:feat/kodo-cache-metadata-artifact

Conversation

@MeteorsLiu

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.06250% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/artifact/kodo.go 89.06% 4 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

@MeteorsLiu MeteorsLiu force-pushed the feat/kodo-cache-metadata-artifact branch 2 times, most recently from 9fd5ecb to b064c46 Compare July 3, 2026 07:55
@MeteorsLiu MeteorsLiu requested a review from luoliwoshang July 3, 2026 07:59
@MeteorsLiu MeteorsLiu force-pushed the feat/kodo-cache-metadata-artifact branch from b064c46 to e7e4a29 Compare July 3, 2026 08:09
@MeteorsLiu MeteorsLiu force-pushed the feat/kodo-cache-metadata-artifact branch from e7e4a29 to 6d380ca Compare July 3, 2026 08:22

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用不到后面就删除吧?经过讨论现在放Kodo了

Comment thread internal/artifact/kodo.go
Comment on lines +119 to +121
if value == "" {
value = metadata["x-qn-meta-"+key]
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark 这里link一下文档

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luoliwoshang luoliwoshang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luoliwoshang luoliwoshang merged commit 35af5d4 into xgo-dev:main Jul 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants