[codex] Update release process sanity guidance#493
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the release process documentation to address dependency resolution for unpublished macros, add development extras to Python verification, and outline procedures for arm64-first Docker releases and TLS certificate generation. Feedback highlights two issues: the automated sanity check script ci/release/sanity.sh needs to be updated with --extra dev for consistency, and the non-existent Rust image tag 1.95 in the Podman smoke test should be replaced with a valid tag or latest to prevent command failures.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| ```shell | ||
| cd sdk/python | ||
| uv run -n pytest tests/test_runner_e2e.py tests/test_runner.py -q | ||
| uv run -n --extra dev pytest tests/test_runner_e2e.py tests/test_runner.py -q |
There was a problem hiding this comment.
The documentation has been updated to include --extra dev for the uv run command. However, the automated sanity check script ci/release/sanity.sh at line 263 still runs uv run -n pytest ... without --extra dev. To ensure consistency and prevent the automated sanity check from failing due to missing dev dependencies, please update ci/release/sanity.sh as well.
| ```shell | ||
| podman info | ||
| podman login --get-login docker.io || podman login docker.io | ||
| podman run --rm --platform linux/amd64 docker.io/library/rust:1.95 rustc -vV |
There was a problem hiding this comment.
The image docker.io/library/rust:1.95 does not exist (as of current Rust releases, which are around 1.84/1.85). Running this command will fail with an image pull error. Consider using latest or a valid Rust version tag to verify the emulation. Note that there are other occurrences of 1.95 in this file (e.g., lines 410, 411, 414, 415) that should also be updated.
| podman run --rm --platform linux/amd64 docker.io/library/rust:1.95 rustc -vV | |
| podman run --rm --platform linux/amd64 docker.io/library/rust:latest rustc -vV |
1a54e95 to
839ee1d
Compare
839ee1d to
ba76929
Compare
Summary
Update
docs/release-process.mdand release helper targets with follow-up guidance from thev0.6.0publish and sanity run.Changes
flame-rs-macrospublish-order issue before finalflame-rspackage verification.CONTAINER_CLI.make helpinclude targets with digits, includinge2e-*, and refresh.PHONYcoverage.release-images-verifyvalidate every platform inRELEASE_IMAGE_PLATFORMSfor all four images.CONTAINER_CLI, then fall back to Podman; keepCONTAINER_RUNTIMEas a backward-compatible override alias.CONTAINER_CLI.CI Fix
The Python E2E and Python System Test failures on head
6cc0d282were caused bymake e2e-py-dockerandmake e2e-py-system-dockerrenderingpodman compose execon GitHub-hosted runners.Those workflows start the cluster with
docker compose up, but the runner also has Podman installed.podman infocan succeed whilepodman composedelegates to the Docker Compose plugin and then tries to connect to/run/user/1001/podman/podman.sock, which is not running in the job.The Makefile now prefers Docker when
docker infosucceeds, falls back to Podman when Docker is unavailable, and usesCONTAINER_CLIconsistently for compose/build/push/run/image commands.Validation
git diff --checkbash -n ci/release/sanity.shpython3 -c 'import py_compile; py_compile.compile("ci/release/check-image-platforms.py", cfile="/tmp/check-image-platforms.pyc", doraise=True)'RELEASE_SANITY_LOCAL_CHECKS=0 RELEASE_SANITY_PACKAGE_CHECKS=0 RELEASE_SANITY_REMOTE_CHECKS=0 RELEASE_SANITY_K8S_E2E=0 RELEASE_SANITY_COMPOSE_E2E=0 make release-sanitymake helpmake -n e2e-py-dockerrendersdocker compose exec ...make -n e2e-py-system-dockerrendersdocker compose exec ...make -n CONTAINER_CLI=podman e2e-py-dockerpreserves the Podman override.make -n CONTAINER_RUNTIME=podman e2e-py-dockerpreserves the legacy alias.docker infoandpodman infosucceeding still rendersdocker compose exec ...for both Python compose targets.make DOCKER_TAG=v0.6.0 CONTAINER_CLI=container-cli -n release-images-verifymake CONTAINER_CLI=container-cli -n ci-imagemake DOCKER_TAG=v0.6.0 CONTAINER_CLI=podman release-images-verifyThe
v0.6.0Docker tags verify as multi-arch for all four images:linux/amd64andlinux/arm64.Note: earlier compose/PyPI Runner smoke passed for the scoped arm64-first state after generating compose TLS certs. The current image verification reflects the later amd64 push.