fetchers: repo: Add git-lfs option#139
Conversation
|
|
|
Hi @josh-bartel, thanks for your contribution. Please add the following lines to the end of your commit message:
Then, maintainers will merge this PR. |
|
|
|
TBH I do not see any other activity of @josh-bartel on GitHub, maybe we can commit and add tags ourselves? @lorc WDYT? |
|
@klogg, I can add |
|
@lorc, get it from original patch: |
68f87e2 to
c6dc279
Compare
|
Added a signoff and reviewed by lines to the commit message |
| repo_args.append(f"-g {groups}") | ||
| git_lfs = self.conf.get("git_lfs", False).as_bool | ||
| if git_lfs: | ||
| repo_args.append(f"--git-lfs") |
There was a problem hiding this comment.
Hi @josh-bartel,
Change this:
repo_args.append(>>>f<<<"--git-lfs")
into this:
repo_args.append("--git-lfs")
in order to fix the following flake8 finding:
Run # stop the build if there are Python syntax errors or undefined names
0
./build/lib/moulin/fetchers/repo.py:67:30: F541 f-string is missing placeholders
./moulin/fetchers/repo.py:67:30: F541 f-string is missing placeholders
2 F541 f-string is missing placeholders
https://github.com/xen-troops/moulin/actions/runs/29094754776/job/86425685501?pr=139
There was a problem hiding this comment.
I pushed a new change to address this.
This adds a git-lfs option to the repo fetcher to support repositories that use git-lfs. Signed-off-by: Josh Bartel <josh.bartel@garmin.com> Reviewed-by: Vladyslav Goncharuk <vladyslav_goncharuk@epam.com>
c6dc279 to
e79a4c1
Compare
This adds a git-lfs option to the repo fetcher to support repositories that use git-lfs.