Skip to content

fetchers: repo: Add git-lfs option#139

Open
josh-bartel wants to merge 1 commit into
xen-troops:mainfrom
josh-bartel:repo-fetcher-add-git-lfs-option
Open

fetchers: repo: Add git-lfs option#139
josh-bartel wants to merge 1 commit into
xen-troops:mainfrom
josh-bartel:repo-fetcher-add-git-lfs-option

Conversation

@josh-bartel

Copy link
Copy Markdown

This adds a git-lfs option to the repo fetcher to support repositories that use git-lfs.

@svlad-90

svlad-90 commented Jun 29, 2026

Copy link
Copy Markdown

Reviewed-by: Vladyslav Goncharuk <vladyslav_goncharuk@epam.com>

@svlad-90

svlad-90 commented Jun 29, 2026

Copy link
Copy Markdown

Hi @josh-bartel, thanks for your contribution.

Please add the following lines to the end of your commit message:

Signed-off-by: YourName YourThirname <your_email>
Reviewed-by: Vladyslav Goncharuk <vladyslav_goncharuk@epam.com>

Then, maintainers will merge this PR.

@lorc

lorc commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>

@klogg

klogg commented Jul 2, 2026

Copy link
Copy Markdown

TBH I do not see any other activity of @josh-bartel on GitHub, maybe we can commit and add tags ourselves? @lorc WDYT?

@lorc

lorc commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

@klogg, I can add Reviewed-by tags, no problem. But I can't add Signed-off-by

@klogg

klogg commented Jul 7, 2026

Copy link
Copy Markdown

@lorc, get it from original patch:
From: Josh Bartel <josh.bartel@garmin.com>

@josh-bartel josh-bartel force-pushed the repo-fetcher-add-git-lfs-option branch from 68f87e2 to c6dc279 Compare July 10, 2026 13:04
@josh-bartel

Copy link
Copy Markdown
Author

Added a signoff and reviewed by lines to the commit message

Comment thread moulin/fetchers/repo.py Outdated
repo_args.append(f"-g {groups}")
git_lfs = self.conf.get("git_lfs", False).as_bool
if git_lfs:
repo_args.append(f"--git-lfs")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @josh-bartel,

Change this:

repo_args.append(>>>f<<<"--git-lfs")

into this:

repo_args.append("--git-lfs")

in order to fix the following flake8 finding:

Run # stop the build if there are Python syntax errors or undefined names
0
./build/lib/moulin/fetchers/repo.py:67:30: F541 f-string is missing placeholders
./moulin/fetchers/repo.py:67:30: F541 f-string is missing placeholders
2     F541 f-string is missing placeholders

https://github.com/xen-troops/moulin/actions/runs/29094754776/job/86425685501?pr=139

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a new change to address this.

This adds a git-lfs option to the repo fetcher to support repositories
that use git-lfs.

Signed-off-by: Josh Bartel <josh.bartel@garmin.com>
Reviewed-by: Vladyslav Goncharuk <vladyslav_goncharuk@epam.com>
@josh-bartel josh-bartel force-pushed the repo-fetcher-add-git-lfs-option branch from c6dc279 to e79a4c1 Compare July 13, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants