Skip to content
This repository was archived by the owner on Jun 9, 2023. It is now read-only.

Fix the AOS version tu20190demo and prod-aos - #72

Open
iusyk wants to merge 1 commit into
xen-troops:masterfrom
iusyk:fox_aos_version_tu2019_aos
Open

Fix the AOS version tu20190demo and prod-aos#72
iusyk wants to merge 1 commit into
xen-troops:masterfrom
iusyk:fox_aos_version_tu2019_aos

Conversation

@iusyk

@iusyk iusyk commented Mar 17, 2020

Copy link
Copy Markdown
Contributor

Signed-off-by: Ihor Usyk ihor_usyk@epam.com

@iusyk
iusyk requested a review from al1img March 17, 2020 20:11
al1img
al1img reviewed Mar 18, 2020
View reviewed changes

@al1img al1img left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also aos-updatemanager, aos-servicemanage and aos-vis should be fixed in appropriate bbappend.

Comment thread prod_aos_minimal/aos.xml Outdated
@iusyk
iusyk force-pushed the fox_aos_version_tu2019_aos branch from daf79d3 to d0cbb92 Compare March 18, 2020 14:17
@iusyk

iusyk commented Mar 18, 2020

Copy link
Copy Markdown
Contributor Author

Also aos-updatemanager, aos-servicemanage and aos-vis should be fixed in appropriate bbappend.

see xen-troops/meta-xt-prod-tu2019-demo#18

@iusyk
iusyk requested review from andr2000, arminn and rshym April 1, 2020 13:58
@rshym

rshym commented Apr 2, 2020

Copy link
Copy Markdown
Contributor

Please fix commit id of fixed component - seems like it is taken from 'master' branch, but should be from 'thud' branch.

@iusyk
iusyk force-pushed the fox_aos_version_tu2019_aos branch from d0cbb92 to b0b6479 Compare April 2, 2020 21:34
@rshym

rshym commented Apr 6, 2020

Copy link
Copy Markdown
Contributor

It's not clear to me why patch modifies manifests for prod-aos.

@rshym

rshym commented Apr 6, 2020

Copy link
Copy Markdown
Contributor

Projects "epmd-aepr/img-proprietary" and "xen-troops/meta-xt-agl-base" still have "revision="master". I think this need to be fixed.

@iusyk

iusyk commented Apr 6, 2020

Copy link
Copy Markdown
Contributor Author

It's not clear to me why patch modifies manifests for prod-aos.

because i has a task to fix aos couple of weeks ago, is it supposed not to change meta-aos in future ?

@iusyk

iusyk commented Apr 6, 2020

Copy link
Copy Markdown
Contributor Author

eta-xt-agl-base

ok, i do

@rshym

rshym commented Apr 17, 2020

Copy link
Copy Markdown
Contributor

Please do nothing with this PR for now, due to ongoing development in other projects.

rshym
rshym suggested changes Apr 28, 2020
View reviewed changes
Comment thread prod_aos/domd.xml
<project remote="linaro" name="openembedded/meta-linaro" path="meta-linaro" upstream="thud" revision="b30036d4ef7ce9fe746833fc54de6ac7b0e00638" />
<project remote="yoctoproject" name="meta-selinux" path="meta-selinux" upstream="thud" revision="fb6192aa2c5df8e80c5e6d4fa5448d574332f68f" />
<project remote="epam" name="epmd-aepr/meta-aos" path="meta-aos" upstream="thud" revision="thud" />
<project remote="epam" name="epmd-aepr/meta-aos" path="meta-aos" upstream="thud" revision="362ffce00ac19f68dd985d7e145b8c815bcd6991" />

@rshym rshym Apr 28, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change this line.
In order to fix prod-aos it's better to follow separate procedure with branches.

@iusyk iusyk Apr 6, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think not, because the prod is frozen, no changes are supposed to be there.

Comment thread prod_aos/domf.xml
<project remote="yoctoproject" name="poky" path="poky" upstream="thud" revision="e7f0177ef3b6e06b8bc1722fca0241fef08a1530" />
<project remote="openembedded" name="meta-openembedded" path="meta-openembedded" upstream="thud" revision="4cd3a39f22a2712bfa8fc657d09fe2c7765a4005" />
<project remote="epam" name="epmd-aepr/meta-aos" path="meta-aos" upstream="master" revision="master" />
<project remote="epam" name="epmd-aepr/meta-aos" path="meta-aos" upstream="master" revision="19f021d6bb5527650b2481caca90982f94ac1a33" />

@rshym rshym Apr 28, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change this line.
In order to fix prod-aos it's better to follow separate procedure with branches.

Comment thread prod_tu2019_demo/domd.xml Outdated
<!-- Xen-troops specific things -->
<project remote="epam" name="epmd-aepr/meta-aos" path="meta-aos" upstream="master" revision="master" />
<project remote="epam" name="epmd-aepr/meta-aos" path="meta-aos" upstream="master" revision="19f021d6bb5527650b2481caca90982f94ac1a33" />
<project remote="epam" name="epmd-aepr/img-proprietary" path="proprietary" upstream="master" revision="master" />

@rshym rshym Apr 28, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set revision for img-proprietary to ef1aa566d74a11c4d2ae9592474030a706b4cf39

Comment thread prod_tu2019_demo/domd.xml Outdated
<project remote="epam" name="epmd-aepr/meta-aos" path="meta-aos" upstream="master" revision="master" />
<project remote="epam" name="epmd-aepr/meta-aos" path="meta-aos" upstream="master" revision="19f021d6bb5527650b2481caca90982f94ac1a33" />
<project remote="epam" name="epmd-aepr/img-proprietary" path="proprietary" upstream="master" revision="master" />
<project remote="github" name="xen-troops/meta-xt-agl-base" path="meta-xt-agl-base" upstream="master" revision="master" />

@rshym rshym Apr 28, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set revision for meta-xt-agl-base to 7c379d746f553ca2c60ddcff464fa8d0aeb6784f

@iusyk
Fix the AOS version tu20190demo and prod-aos
53bb6d3 
Signed-off-by: Ihor Usyk <ihor_usyk@epam.com>
@iusyk
iusyk force-pushed the fox_aos_version_tu2019_aos branch from b0b6479 to 53bb6d3 Compare April 6, 2021 10:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andr2000 andr2000 Awaiting requested review from andr2000
@arminn arminn Awaiting requested review from arminn
2 more reviewers
@al1img al1img al1img left review comments
@rshym rshym rshym requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iusyk @rshym @al1img