Simplify CIF helper functions in pdb_deposition.py - #86
Merged
Conversation
- Remove unused functions: append_data_to_values and prune_loop - Remove dict_to_tags_values (trivial); inline at call site with list(d.keys())/list(d.values()) - Inline add_row_if_not_excluded into collect_entity_values - Merge delete_pair_item + delete_loop_item into delete_cif_items (keyword args select item type) - Merge append_loop_items + combine_diffrn_loops into build_loop (None-safe, handles both use cases) Closes #85 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
append_data_to_values,prune_loop)dict_to_tags_values; inline at call siteadd_row_if_not_excludedintocollect_entity_valuesdelete_pair_item+delete_loop_item→delete_cif_items(keyword argspairs=/loops=)append_loop_items+combine_diffrn_loops→build_loop(None-safe); fixes docstring copy-paste bugNet: 14 functions → 9, 138 lines deleted. All 65 tests pass.
Closes #85
Test plan
pytest tests/— 65 passed, 0 failed🤖 Generated with Claude Code