Replace use of PluginManager with Cntlr.plugins#45
Open
aaroncameron-wk wants to merge 1 commit into
Open
Conversation
aaroncameron-wk
force-pushed
the
plugin-provider
branch
from
ffcd67e to
b963d33
Compare
volodymyrtur-wk
approved these changes
May 7, 2026
|
|
||
| def getSxmModule(cntlr): | ||
| if _SXM_PLUGIN_NAME not in cntlr.plugins.get_plugins(): | ||
| cntlr.addToLog(_("'{plugin_name}'' plugin is not loaded. '{plugin_name}' plugin is required. " |
There was a problem hiding this comment.
Suggested change
| cntlr.addToLog(_("'{plugin_name}'' plugin is not loaded. '{plugin_name}' plugin is required. " | |
| cntlr.addToLog(_("'{plugin_name}' plugin is not loaded. '{plugin_name}' plugin is required. " |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Refactor plugin invocation to align with the upcoming deprecation of the global
PluginManagerin Arelle. This update migrates logic to use thePluginProviderinstance provided by theCntlr(accessible viacntlr.plugins).Questions:
I noticed the
Do not change anything below this linecomment, but I'm not familiar with the context around that. Perhaps this code is generated/copied from somewhere else?@campbellpryde
@davidtauriello