CA-428620: fix occasional vm suspend error#7134
Open
chunjiez wants to merge 1 commit into
Open
Conversation
chunjiez
force-pushed
the
private/chunjiez/bugfix
branch
from
9a46060 to
74337af
Compare
data-cant-suspend-reason is not a reliable basis to decide whether a VM can be suspended, in some corner case, vm suspend operation runs into error, State blocked by non-migratable device 0000:00:07.0/nvme Signed-off-by: Chunjie Zhu <chunjie.zhu@citrix.com>
chunjiez
force-pushed
the
private/chunjiez/bugfix
branch
from
74337af to
a1564d4
Compare
gthvn1
requested changes
Jun 18, 2026
gthvn1
left a comment
gthvn1
left a comment
Contributor
There was a problem hiding this comment.
Interesting. It looks good to me, just few questions.
| let restore _ _cb vm vbds vifs data vgpu_data extras = | ||
| with_lock m (restore_nolock vm vbds vifs data vgpu_data extras) | ||
|
|
||
| let resume _ _vm = () |
| let lack_feature feature = not (has_feature ~vmgmr ~feature) in | ||
| match op with | ||
| | (`suspend | `checkpoint | `pool_migrate | `migrate_send) when is_live -> ( | ||
| | (`pool_migrate | `migrate_send) when is_live -> ( |
Contributor
There was a problem hiding this comment.
I think I understand the split but don't we have the same problem of false negatives here?
last-genius
reviewed
Jun 18, 2026
| let lack_feature feature = not (has_feature ~vmgmr ~feature) in | ||
| match op with | ||
| | (`suspend | `checkpoint | `pool_migrate | `migrate_send) when is_live -> ( | ||
| | (`pool_migrate | `migrate_send) when is_live -> ( |
Contributor
There was a problem hiding this comment.
With this, migrations are still blocked in xapi, while suspend is allowed.
There's already an assert_can_save in VM_migrate in xenopsd, should it not be moved together with suspend and checkpoint here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data-cant-suspend-reason is not a reliable basis to decide
whether a VM can be suspended, in some corner case, vm suspend
operation runs into error,
State blocked by non-migratable device 0000:00:07.0/nvme