Configure LLDP advertising on physical NICs#7131
Open
minglumlu wants to merge 5 commits into
Open
Conversation
Signed-off-by: Ming Lu <ming.lu@cloud.com>
Add an Lldp module that manages lldpd via lldpcli to advertise the LLDP information for individual physical NICs on a host. This is done by the networkd interface `Interface.make_config`. lldpd is a user space LLDP agent running in dom0. lldpcli is a client to configure/query LLDP TLVs to/from lldpd. Signed-off-by: Ming Lu <ming.lu@cloud.com>
One of the advertising LLDP TLV is management address(es) of the host. This data is shared by the NICs with LLDP feature enabled. However, the address(es) on management interface on a host may change. This change can be caught by network_monitor_thread. Consequently, a callback is carried out to update this specific LLDP TLV configuration. Signed-off-by: Ming Lu <ming.lu@cloud.com>
This is for the safety of using CNA or hardware iSCSI in which case the NIC and a storage function share the same hardware. Enabling LLDP on such NICs may fail the corresponding storage function. Users can enable it with PIF level configuration if it is confirmed no impact on the storage function. Signed-off-by: Ming Lu <ming.lu@cloud.com>
Some NICs run an LLDP agent in firmware, which would conflict with
lldpd. Before enabling LLDP on an interface, disable the firmware agent
on a best-effort basis via ethtool private flags ("disable-fw-lldp" and
"fw-lldp-agent").
The "best-effort" means that not all NICs support firmware LLDP; for the
supported ones, not all can be turned off from dom0. Users can turn off
the firmware LLDP from UEFI host settings.
Overall, the conflict is not supposed to impact other functions. So it's
a try on best-effort.
Signed-off-by: Ming Lu <ming.lu@cloud.com>
minglumlu
force-pushed
the
private/mingl/CP-312088
branch
from
c855628 to
211e0d6
Compare
last-genius
reviewed
Jun 17, 2026
Comment on lines
+39
to
+46
| type conf = | ||
| | Chassis_id of chassis_id | ||
| | Port_id of dev * port_id | ||
| | Port_description of dev * port_description | ||
| | System_name of string | ||
| | System_description of string | ||
| | System_capability of system_capability list | ||
| | Multicast_address of I.lldp_multicast_address list |
Contributor
There was a problem hiding this comment.
I don't particularly see the point of conf being a list of these variants - why not a record? As I understand, each of these variants can only be applied once, right?
Member
Author
There was a problem hiding this comment.
One of them, management_address, may be set separately due to network change. And once it happens, other confs should not be changed.
Contributor
There was a problem hiding this comment.
But this is already ensured by the cache, no?
Member
Author
There was a problem hiding this comment.
Cache is unrelated here. The usual path is all of these confs is set for individual NICs. But another path is that the management_address alone could be set by the monitor thread in which case constructing all fields is awkward.
| let cache_mc_addr : conf option Atomic.t = Atomic.make None | ||
|
|
||
| let cache_mgmt_addr: conf option Atomic.t = Atomic.make None | ||
| let cache_mgmt_addr : conf option Atomic.t = Atomic.make None |
Contributor
There was a problem hiding this comment.
Formatting changes that belong to the previous commit here and above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR of LLDP feature. The overall design doc is https://github.com/xapi-project/xen-api/blob/master/doc/content/design/lldp.md
The PR is for managing a LLDP agent (and one implementation
lldpd) and configuring for individual NICs through LLDP client. Cache is used to avoid unnecessary calls of LLDP client as most of configurations are shared by NICs.